1909479 - 5.12 - 2.01% pdfpaint issue5726.pdf / pdfpaint issue6238.pdf + 12 more (Linux, OSX, Windows) regression on Fri July 12 2024

Status: RESOLVED WONTFIX

(Core :: Graphics: Canvas2D, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push ee5a9539eddd7ddee409b23f3e5c53fb4ac3494c. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
5%	pdfpaint issue5726.pdf	windows11-64-shippable-qr	e10s fission stylo webrender-sw	282.66 -> 297.13
5%	pdfpaint annotation-as.pdf	windows11-64-shippable-qr	e10s fission stylo webrender-sw	316.15 -> 332.30
4%	pdfpaint issue5726.pdf	windows11-64-shippable-qr	e10s fission stylo webrender	282.38 -> 295.04
4%	pdfpaint issue5726.pdf	windows11-64-shippable-qr	e10s fission stylo webrender	281.99 -> 293.67
3%	pdfpaint issue13931.pdf	windows11-64-shippable-qr	e10s fission stylo webrender	432.05 -> 445.79
3%	pdfpaint issue11922_reduced.pdf	macosx1015-64-shippable-qr	e10s fission stylo webrender	202.96 -> 209.18
3%	pdfpaint issue13931.pdf	windows11-64-shippable-qr	e10s fission stylo webrender-sw	431.94 -> 444.16
2%	pdfpaint issue4090.pdf	linux1804-64-shippable-qr	e10s fission stylo webrender	602.96 -> 617.96
2%	pdfpaint issue3248.pdf	windows11-64-shippable-qr	e10s fission stylo webrender-sw	230.58 -> 236.17
2%	pdfpaint S2.pdf	windows11-64-shippable-qr	e10s fission stylo webrender	253.68 -> 259.46
2%	pdfpaint jbig2_huffman_2.pdf	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	386.93 -> 395.28
2%	pdfpaint issue10491.pdf	windows11-64-shippable-qr	e10s fission stylo webrender-sw	279.52 -> 285.53
2%	pdfpaint issue3248.pdf	windows11-64-shippable-qr	e10s fission stylo webrender	232.92 -> 237.94
2%	pdfpaint issue6238.pdf	windows11-64-shippable-qr	e10s fission stylo webrender	521.38 -> 531.85

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	pdfpaint personwithdog.pdf	windows11-64-shippable-qr	e10s fission stylo webrender	165.08 -> 160.26

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1259

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1904048

Comment 2

[Lee Salzman [:lsalzman]]

This is expected. GCing of ImageBitmap was effectively disabled due to a bug, causing uncontrolled memory use.

We now properly GC the ImageBitmap garbage accumulation, which will lead to some performance cost to ensure memory is properly cleaned up.