1909508 - allow model loading without running an inference

Status: RESOLVED FIXED

(Core :: Machine Learning: General, enhancement)

Description

[Tarek Ziadé (:tarek)]

Right now the model download happens lazily on the first run() but that makes the UI in pdf.js hard to build because we want to download models before the first run

Let's add the ability to optionally trigger this initialization independently from a run, and have createEngine await for it

Comment 1

[Aristide Tossou]

@tarek I am taking this bug and putting it into 130. Fixing this bug makes the solution for https://bugzilla.mozilla.org/show_bug.cgi?id=1910627 easier.

Comment 2

[Aristide Tossou]

Attachment: Bug 1909508 - allow model loading without running an inference - r?tarek,calixte

Comment 3

[Tarek Ziadé (:tarek)]

The patch is quite large and complex - since we don't need it for 130, let's hold it and do it in 131.

For https://bugzilla.mozilla.org/show_bug.cgi?id=1910627 we can call the delete of the model in the flow

Comment 4

[Aristide Tossou]

This patch is not changing many things. It is mostly just adding await here and there

It felt like big because we cannot await in constructor. So first we need to refactor the code into constructor + static initialization (with no changes in behavior).

I can add a global flag that will disable the features it brings (ability to await for full initialization) as originally suggested for this bug.

That way we would be able to land it.

Comment 5

[Aristide Tossou]

Attachment: Bug 1909508 - allow model loading without running an inference - r?tarek,calixte

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62f9907a4c1c
allow model loading without running an inference - r=tarek

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/62f9907a4c1c