1909591 - [wpt-sync] Sync PR 47269 - Input event data should not be null when replace selection command is performed

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47269 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47269
Details from upstream follow.

Utkarsh Pathak <[e-mail]> wrote:

Input event data should not be null when replace selection command is performed

As per spec
https://www.w3.org/TR/input-events-1/#overview, event data for input
events with certain inputType should be set with the data under
operation. Currently, the event data is null since the method
|TextDataForInputEvent| was not implemented in |ReplaceSelectionCommand|
class, which is implemented in this CL. |ReplaceSelectionCommand|
objects are populated with insertFromDrop, insertFromPaste,
insertReplacementText, insertTranspose and none inputType. This change
will set the data for input events with inputType insertFromDrop,
insertFromPaste and insertReplacementText leaving the insertTranspose
and none inputType data null as per the spec. For other input types,
other class objects derived from |EditCommand| are created, which is not
in the scope of this CL and can be handled separately.

Bug: 40737336
Change-Id: Ia7557f4d4fb239585be8fbcc5cdb489b77799c3f
Reviewed-on: https://chromium-review.googlesource.com/5605567
WPT-Export-Revision: 87274364c45ee15c0252394d96496ad9c79942f0

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=81fba09f23b5afe9b70021e72b52ade7e037f804

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
FAIL: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /input-events/contenteditable-insertfrompaste-type-inputevent-data.html [wpt.fyi]
  • Input event data for inputType insertFromPaste should not be set for contenteditable: FAIL (Chrome: FAIL, Safari: FAIL)
• /input-events/textarea-insertfrompaste-type-inputevent-data.html [wpt.fyi]
  • Input event data for inputType insertFromPaste should be set: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbf109d948b4
[wpt PR 47269] - Input event data should not be null when replace selection command is performed, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4ca04bae7cea
[wpt PR 47269] - Update wpt metadata, a=testonly

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fbf109d948b4
https://hg.mozilla.org/mozilla-central/rev/4ca04bae7cea