1909606 - Remove some WPT meta data which is automatically deleted when running `./mach wpt-update ...`

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, task)

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1909606: remove some WPT meta data for webgpu. r=jgraham

./mach wpt-update someFile.json deletes them. Presumably it was
forgotten to remove them since at least some of the corresponding .html
files don't exist.

Comment 2

[Erich Gubler [:ErichDonGubler] (he/him)]

I should review this patch, actually. There's a very weird story behind these files, esp. since the WebGPU team has automation that will automatically regenerate these files until WebGPU CTS is re-vendored. 😓

Will explain once I'm not on mobile.

Comment 3

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1909606 - test(webgpu): fix extensions of `webworker` test metadata r=#webgpu-reviewers

This was caused by incorrect handling of *.worker.js test in
moz-webgpu-cts 0.10.1. It is fixed upstream with
moz-webgpu-cts#119.

Comment 4

[Erich Gubler [:ErichDonGubler] (he/him)]

The current patch (D217550) states:

Presumably it was forgotten to remove them since at least some of the corresponding .html files don't exist.

There actually are *.worker.html entries being reported by wptrunner that these "forgotten" files relate to. However, the authored extension of these "tests" (more on that momentarily) is *.worker.js, and the metadata should be using *.worker.js.ini, but mistakenly uses *.worker.html.ini instead.

The above happens because I had written automation that, until recently, was not smart enough to handle mapping from *.worker.html entries in wptreport.jsons to *.worker.js files. I've just attached a patch with details on the tooling that did this, and when things were fixed, but the short summary is: Sorry, this my bad! 😅 This patch renders D217550 obsolete, so I will be commandeering and abandoning it.

Comment 6

[Erich Gubler [:ErichDonGubler] (he/him)]

:mbrodesser-igalia:☝🏻With D217716, can you please confirm that this issue is resolved?

Comment 7

[Erich Gubler [:ErichDonGubler] (he/him)]

Example of the running tests in question: https://treeherder.mozilla.org/logviewer?job_id=467674146&repo=try&lineNumber=1879-1880

[task 2024-07-24T05:59:58.116Z] 05:59:58     INFO - TEST-START | /_mozilla/webgpu/cts/webworker/api/operation/reflection.worker.html
[task 2024-07-24T05:59:58.117Z] 05:59:58     INFO - TEST-SKIP | /_mozilla/webgpu/cts/webworker/api/operation/reflection.worker.html | took 0ms

For context, these are SKIPped because they are disabled in testing/web-platform/mozilla/meta/webgpu/cts/webworker/__dir__.ini:1, to work around the fact that CTS generates *.worker.js files without actually intending them to be WPT tests. 😮‍💨

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c68ea84b6959
test(webgpu): fix extensions of `webworker` test metadata r=webgpu-reviewers,nical

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/c68ea84b6959

Comment 10

[Erich Gubler [:ErichDonGubler] (he/him)]

Going to close for now, but leave the NI so we get feedback (just in case).

Comment 11

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Ran ./mach wpt-update someFile again on today's Gecko and the problem didn't reoccur.

Comment 12

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Today ./mach wpt-update lead to:

[...]
deleted: testing/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/execution/value_init/cts.https.html.ini
deleted: testing/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/validation/expression/access/structure/cts.https.html.ini

Comment 13

[Erich Gubler [:ErichDonGubler] (he/him)]

These issues should go away once the rest of the patch series for bug 1909753 finishes landing. 🤞🏻 I had incorrectly split out some of the new tests in that CTS re-vendor into a patch that was supposed to only trim tests no longer being reported. 😅

Comment 14

[Erich Gubler [:ErichDonGubler] (he/him)]

With patches for bug 1909753 landed in central, I think only the following cases will be automatically deleted by wpt-update invocations now:

testing/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/validation/parse/builtin/cts.https.html.ini
testing/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/validation/parse/const/cts.https.html.ini
testing/web-platform/mozilla/meta/webgpu/cts/webgpu/shader/validation/parse/unary_ops/cts.https.html.ini

Added their removal as a patch here. :mbrodesser-igalia, can you please confirm that this resolves the issue once again for you?

Comment 15

[Erich Gubler [:ErichDonGubler] (he/him)]

Attachment: Bug 1909606 - clean up straggler meta. of removed tests r=#webgpu-reviewers

Comment 16

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Added their removal as a patch here. :mbrodesser-igalia, can you please confirm that this resolves the issue once again for you?

Erich: please ni?-me once this is ready.

Comment 17

[Erich Gubler [:ErichDonGubler] (he/him)]

I don't know whay you mean by "ready" or "it", but I suspect the patch already is. There's no reason to wait to validate; you can check apply the patch manually and see if it works.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ddd6d4b8034
clean up straggler meta. of removed tests r=webgpu-reviewers,teoxoy

Comment 19

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1ddd6d4b8034

Comment 20

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Checked with today's mozilla-central and ./mach wpt-update someFile didn't remove any webgpu files.