1909625 - CSS zoom property also affects text on canvas

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[6k64x4ma]

Attachment: test.html

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

Load the attached file.

Actual results:

The result is "96px serif" on Firefox, but "48px serif" on Microsoft Edge.

Expected results:

Maybe Firefox should align with Edge.

Comment 1

[6k64x4ma]

Attachment: Edge vs Firefox

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1909625 - Ignore CSS zoom and text zoom for canvas. r=#layout,#gfx-reviewers

The spec doesn't mention anything about applying them, and other
browsers don't, so let's just be consistent...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfb3a55370d3
Ignore CSS zoom and text zoom for canvas. r=gfx-reviewers,lsalzman

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48083 for changes under testing/web-platform/tests

Comment 6

[tszentpeteri]

Backed out for causing mochitest failures on test_canvas_font_setter.html.

• Backout link
• Push with failures
• Failure Log:

[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -  TEST-PASS | dom/canvas/test/test_canvas_font_setter.html | text should be wider at 66px than at 20px
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -  Buffered messages finished
[task 2024-09-10T20:32:29.432Z] 20:32:29  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/test_canvas_font_setter.html | font size set using em units serializes to px - got "0px serif", expected "66px serif"
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      @dom/canvas/test/test_canvas_font_setter.html:50:3
[task 2024-09-10T20:32:29.432Z] 20:32:29  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/test_canvas_font_setter.html | em should be relative to canvas font size - got +0, expected 145.35000610351562
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      @dom/canvas/test/test_canvas_font_setter.html:51:3
[task 2024-09-10T20:32:29.432Z] 20:32:29  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/test_canvas_font_setter.html | font size set using em units serializes to px - got "0px serif", expected "66px serif"
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      @dom/canvas/test/test_canvas_font_setter.html:53:3
[task 2024-09-10T20:32:29.432Z] 20:32:29  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/test_canvas_font_setter.html | em should be relative to canvas font size at time of setting - got +0, expected 145.35000610351562
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      @dom/canvas/test/test_canvas_font_setter.html:54:3
[task 2024-09-10T20:32:29.432Z] 20:32:29  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/test_canvas_font_setter.html | font size set using em units serializes to px - got "0px serif", expected "66px serif"
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      @dom/canvas/test/test_canvas_font_setter.html:57:3
[task 2024-09-10T20:32:29.432Z] 20:32:29  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/test_canvas_font_setter.html | em should be relative to canvas font size at time of setting - got +0, expected 145.35000610351562
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      @dom/canvas/test/test_canvas_font_setter.html:58:3
[task 2024-09-10T20:32:29.432Z] 20:32:29  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/test_canvas_font_setter.html | font size set using em units serializes to px - got "0px serif", expected "20px serif"
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      @dom/canvas/test/test_canvas_font_setter.html:62:3
[task 2024-09-10T20:32:29.432Z] 20:32:29  WARNING -  TEST-UNEXPECTED-FAIL | dom/canvas/test/test_canvas_font_setter.html | em should be relative to 10px when canvas not in document - got +0, expected 44.03333282470703
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      SimpleTest.is@SimpleTest/SimpleTest.js:509:14
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -      @dom/canvas/test/test_canvas_font_setter.html:63:3
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -  TEST-OK | dom/canvas/test/test_canvas_font_setter.html | took 198ms
[task 2024-09-10T20:32:29.432Z] 20:32:29     INFO -  TEST-START | dom/canvas/test/test_canvas_path.html

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2de2533b5e62
Ignore CSS zoom and text zoom for canvas. r=gfx-reviewers,lsalzman

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2de2533b5e62

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot