Closed Bug 1909632 Opened 1 year ago Closed 1 year ago

Page content disappears when auto-translate is enabled.

Categories

(Firefox :: Translations, defect, P3)

Firefox 130
Desktop
Windows 10
defect

Tracking

()

RESOLVED FIXED
134 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- wontfix
firefox128 --- wontfix
firefox129 --- wontfix
firefox130 --- wontfix
firefox131 --- wontfix
firefox132 --- wontfix
firefox133 --- wontfix
firefox134 --- fixed

People

(Reporter: railioaie, Assigned: gregtatum)

References

(Depends on 1 open bug, Regression, )

Details

(Keywords: regression, Whiteboard: [webcompat-source:product])

Attachments

(5 files)

Environment:
Operating system: Windows 10
Firefox version: Firefox 128.0 (release)/ Firefox Nightly 130

Preconditions:

  • ETP set to STRICT
  • Clean profile

Steps to reproduce:

  1. Navigate to: https://schnapsen.online/spielen
  2. Click on Register

Expected Behavior:
Registration page displayed

Actual Behavior:
The registration page is not displayed properly

Notes:

  • Not reproducible with ETP STANDARD/turned OFF (both Normal and Private Browsing)
  • Reproducible on the latest Nightly

Created from webcompat-user-report:83020685-935c-45bc-b2d6-529ecc340dd0

Attached image Screenshot_86.png

This appears to be working for us in the triage meeting - can you recheck?

Flags: needinfo?(railioaie)

Hi, It's still reproducible. Please click on register to check.

Flags: needinfo?(railioaie)
Attached image Screenshot_4.png

A-ha, so we figured out that this is actually an issue with Firefox Translate! If you set it to "always translate German", the content just... disappears.

Component: Site Reports → Translations
Product: Web Compatibility → Firefox

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

The severity field is not set for this bug.
:nordzilla, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(enordin)

Interesting, this does seem to be an issue specific to having auto-translate enabled.

I used mozregression and narrowed it down to Bug 1837424, which seems to have caused the issue.


Steps to reproduce

Expected Behavior
The page is translated from German to the user's target language.

Actual Behavior
The main content of the page disappears after translation starts.


I have not yet taken the time to look further into what code change within Bug 1837424 may have caused this.

Severity: -- → S3
Flags: needinfo?(enordin)
Summary: schnapsen.online - The registration page is not displayed properly with ETP set to Strict → Page content disappears when auto-translate is enabled.
Keywords: regression
Regressed by: 1837424

Set release status flags based on info from the regressing bug 1837424

:gregtatum, since you are the author of the regressor, bug 1837424, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(gtatum)

This is a race between the initial translation and a mutation that happens. We need to keep track of submitted nodes and cancel the translation if a mutation happens, then re-submit with the mutation.

Flags: needinfo?(gtatum)

Set release status flags based on info from the regressing bug 1837424

I've been working on this, and it requires a pretty big change in the implementation to properly handle, so I wouldn't recommend uplifting the change.

Assignee: nobody → gtatum
Attachment #9431066 - Attachment description: WIP: Bug 1909632 - Move the createTranslationsDoc to shared test code; r?#translations-reviewers! → Bug 1909632 - Move the createTranslationsDoc to shared test code; r?#translations-reviewers!
Attachment #9431067 - Attachment description: WIP: Bug 1909632 - Cancel translations that are mutated and re-submit them; r?#translations-reviewers! → Bug 1909632 - Cancel translations that are mutated and re-submit them; r?#translations-reviewers!

I busted this test while working on this patch, and found the assertion
confusing with the somewhat incorrect Spanish.

Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30ac0bfbcc8c Move the createTranslationsDoc to shared test code; r=translations-reviewers,nordzilla https://hg.mozilla.org/integration/autoland/rev/197d1d95f847 Cancel translations that are mutated and re-submit them; r=translations-reviewers,nordzilla https://hg.mozilla.org/integration/autoland/rev/34b62cca9618 Refactor confusing pseudo-spanish in test; r=translations-reviewers,nordzilla
Flags: in-testsuite+
Regressions: 1932780
Regressions: 1934997
Duplicate of this bug: 1904260
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: