1909638 - NSS automation should always cleanup the NSPR tree

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Kai Engert (:KaiE:)]

When running NSS try builds that also contain an nspr.patch, the changes to NSPR might get stuck on the workers checkout.

We should always reset the NSPR tree.

I think it's easiest to simply use "hg revert", then we don't have to lookup any tags.

Because we don't have separate NSPR build/test infrastructure, I suggest that we continue to always build/test the most recent snapshot of NSPR.
That way, new NSPR commits will always be tested as part of our NSS automation, even when there's no new official NSPR release yet.

Comment 1

[Kai Engert (:KaiE:)]

Sigh, sorry. Instead of pushing my attempted fix to phabricator, I accidentally pushed the patch to mercurial directly....

Comment 2

[Kai Engert (:KaiE:)]

John, can the change remain, or should I back out?
https://hg.mozilla.org/projects/nss/rev/91cebd0929539141c551b0ce8716a134a63becc8

Comment 3

[John Schanck [:jschanck]]

The patch looks good to me and CI is green. r+.

Comment 4

[Kai Engert (:KaiE:)]

Reopening.

Although the cleanup part probably works right, my change broke the NSPR patch operation.

Because I moved the directory change to a an earlier place, the check for the existing file will always fail and patching will be skipped.
I need to update the check.

Comment 5

[Kai Engert (:KaiE:)]

Attachment: Bug 1909638 - Follow-up to fix test for presence of file nspr.patch. r=jschanck

Comment 6

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nss/rev/51a800758d390f3de389ff1d3fc480beb6aad267

confirmed on try-server that it applies the patch.