1909655 - [wpt-sync] Sync PR 47273 - Add extra synchronization to test.

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47273 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47273
Details from upstream follow.

W. James MacLean <[e-mail]> wrote:

Add extra synchronization to test.

This CL adds an additional synchronization point in the test
storage-access-permission.sub.https.window.js. This test installs a
permission-change observer, then initiates a permission change. But the
observer installation is itself asynchronous, and it seems possible the
change the test is trying to observe could occur without the observer
finishing its installation, causing the test to flake. This CL removes
this possibility by forcing the test to wait for the observer
installation to complete before initiating the change the observeer is
intended to observe.

This test has been observed flaking at
https://github.com/web-platform-tests/wpt/runs/27636425026, so it is
hoped this CL will eliminate that flake.

Bug: 40259221
Change-Id: I23e3aa10a3e1e635cc60b17e6ce8445012b6964c
Reviewed-on: https://chromium-review.googlesource.com/5734161
WPT-Export-Revision: bae7a3fb5e637ea078a1bf8b60eb661b3a6cbfb2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=013d44a00c45f5e92c1ce6c2ce03e4f494544797

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS : 5
FAIL : 2

Chrome

PASS : 2
FAIL : 3
TIMEOUT: 3

Safari

TIMEOUT: 2
NOTRUN : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /storage-access-api/storage-access-permission.sub.https.window.html [wpt.fyi]
  • Permissions grants are observable across same-origin iframes: FAIL (Chrome: FAIL, Safari: TIMEOUT)
  • Permissions grants are observable across same-site iframes: FAIL (Chrome: FAIL, Safari: NOTRUN)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04b49767f759
[wpt PR 47273] - Add extra synchronization to test., a=testonly

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/04b49767f759