1909729 - Flip PPA pref on Android

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Brian Grinstead [:bgrins]]

PPA & DAP aren’t well-tested on Android, and outside of the telemetry opt-out there’s not a good settings UI in Fenix to opt out. It’s also unnecessary to ship the prototype on Android to inform standards work, so disable it.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1909729 - Disable PPA submission and trial on Android by default. r=bgrins

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ca1cc34e390
Disable PPA submission and trial on Android by default. r=bgrins

Comment 3

[tszentpeteri]

Backed out for causing mochitest fails related to test_meta_simple.html

• Backout link
• Push with failures
• Failure Log:

[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  TEST-PASS | dom/origin-trials/tests/mochitest/test_meta_simple.html | CoepCredentialless trial works.
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  Buffered messages finished
[task 2024-07-24T22:47:39.721Z] 22:47:39  WARNING -  TEST-UNEXPECTED-FAIL | dom/origin-trials/tests/mochitest/test_meta_simple.html | PrivateAttribution trial works.
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:426:16
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  @https://example.com/tests/dom/origin-trials/tests/mochitest/test_meta_simple.html:14:7
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  nextTick/<@https://example.com/tests/SimpleTest/SimpleTest.js:2189:34
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  async*nextTick@https://example.com/tests/SimpleTest/SimpleTest.js:2233:11
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  setTimeout handler*SimpleTest_setTimeoutShim@https://example.com/tests/SimpleTest/SimpleTest.js:922:41
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  add_task@https://example.com/tests/SimpleTest/SimpleTest.js:2137:17
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  assertTestTrialActive@https://example.com/tests/dom/origin-trials/tests/mochitest/common.js:44:11
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  @https://example.com/tests/dom/origin-trials/tests/mochitest/test_meta_simple.html:11:24
[task 2024-07-24T22:47:39.721Z] 22:47:39  WARNING -  TEST-UNEXPECTED-FAIL | dom/origin-trials/tests/mochitest/test_meta_simple.html | PrivateAttribution trial works.
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  SimpleTest.ok@https://example.com/tests/SimpleTest/SimpleTest.js:426:16
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  @https://example.com/tests/dom/origin-trials/tests/mochitest/test_meta_simple.html:15:7
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  nextTick/<@https://example.com/tests/SimpleTest/SimpleTest.js:2189:34
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  async*nextTick@https://example.com/tests/SimpleTest/SimpleTest.js:2233:11
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  setTimeout handler*SimpleTest_setTimeoutShim@https://example.com/tests/SimpleTest/SimpleTest.js:922:41
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  add_task@https://example.com/tests/SimpleTest/SimpleTest.js:2137:17
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  assertTestTrialActive@https://example.com/tests/dom/origin-trials/tests/mochitest/common.js:44:11
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  @https://example.com/tests/dom/origin-trials/tests/mochitest/test_meta_simple.html:11:24
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  add_task | Leaving
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  TEST-OK | dom/origin-trials/tests/mochitest/test_meta_simple.html | took 518ms
[task 2024-07-24T22:47:39.721Z] 22:47:39     INFO -  TEST-START | dom/origin-trials/tests/mochitest/test_subdomain.html

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41ba3827b545
Disable PPA submission and trial on Android by default. r=bgrins

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9414689 [details]
Bug 1909729 - Disable PPA submission and trial on Android by default. r=bgrins

Beta/Release Uplift Approval Request

• User impact if declined: We don't want PPA enabled on android without a user-facing setting to turn it off.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): pref flip for something that is gated by origin trials.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/41ba3827b545

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9414689 [details]
Bug 1909729 - Disable PPA submission and trial on Android by default. r=bgrins

Approved for 129.0b9 and 128.0.3.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7c0cc497953c

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/38b9888273f8