1909754 - Intermittent [TV] toolkit/components/reader/tests/browser/browser_readerMode_colorSchemePref.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: tszentpeteri [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=467779690&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/L3s1xK0pRBi9kfX-Zmg3og/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/L3s1xK0pRBi9kfX-Zmg3og/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2024-07-24T20:34:38.419Z] 20:34:38     INFO - TEST-PASS | toolkit/components/reader/tests/browser/browser_readerMode_colorSchemePref.js | Focus moves back to the Custom tab - {} == {} - 
[task 2024-07-24T20:34:38.419Z] 20:34:38     INFO - Leaving test bound 
[task 2024-07-24T20:34:38.419Z] 20:34:38     INFO - Buffered messages finished
[task 2024-07-24T20:34:38.420Z] 20:34:38     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/reader/tests/browser/browser_readerMode_colorSchemePref.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2024-07-24T20:34:38.420Z] 20:34:38     INFO - GECKO(2498) | MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
[task 2024-07-24T20:34:38.420Z] 20:34:38     INFO - GECKO(2498) | MEMORY STAT | vsize 8141MB | residentFast 307MB | heapAllocated 141MB
[task 2024-07-24T20:34:38.421Z] 20:34:38     INFO - TEST-OK | toolkit/components/reader/tests/browser/browser_readerMode_colorSchemePref.js | took 46039ms
[task 2024-07-24T20:34:38.421Z] 20:34:38     INFO - checking window state
[task 2024-07-24T20:34:38.421Z] 20:34:38     INFO - GECKO(2498) | Completed ShutdownLeaks collections in process 2498
[task 2024-07-24T20:34:38.422Z] 20:34:38     INFO - TEST-START | Shutdown

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:ini, since you are the author of the regressor, bug 1907280, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1907280

Comment 3

[Intermittent Failures Robot]

1 failures in 4124 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Platform and build breakdown:

• macosx1015-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1909754&startday=2024-07-22&endday=2024-07-28&tree=all

Comment 4

[Irene Ni]

I have submitted a patch to split up the test file.

Comment 5

[Irene Ni]

Attachment: Bug 1909754 - Split up browser_readerMode_colorSchemePref.js. r=#reader-mode-reviewers

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1907280

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1028a1213c96
Split up browser_readerMode_colorSchemePref.js. r=reader-mode-reviewers,Gijs

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1028a1213c96

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ini, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox130 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Irene Ni]

requesting uplift.

Comment 11

[Irene Ni]

Attachment: Bug 1909754 - Split up browser_readerMode_colorSchemePref.js. r=#reader-mode-reviewers

Original Revision: https://phabricator.services.mozilla.com/D218385

Comment 12

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: would cause intermittent test failures
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: Low
• Explanation of risk level: splitting up existing unit tests that were timing out
• String changes made/needed: n/a
• Is Android affected?: no

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/7c42189f419e