Cleanup related to intrinsic size computation
Categories
(Core :: Layout, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox130 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
Details
Attachments
(5 files)
Let's have more cleanup patches in preparation towards Bug 1909761.
|
Assignee | |
Comment 1•2 months ago
|
||
-
Replace "width" with "inline-size" in comments and member variables. Also,
align the terms such as "min-content inline size" with the spec
https://drafts.csswg.org/css-sizing-3/#auto-box-sizes -
Initialize member variables directly.
|
||
Updated•2 months ago
|
|
|
Assignee | |
Comment 3•2 months ago
|
||
BRFrame inherits from nsIFrame, and nsIFrame's default implementation for both
methods return 0.
|
|
Assignee | |
Comment 4•2 months ago
|
||
nsCheckboxRadioFrame was renamed from nsFormControlFrame in [1]. When it was
still called nsFormControlFrame, its GetIntrinsicISize() method was removed
and ComputeAutoSize() was changed to do more than just returning the intrinsic
size in [2].
[1] https://hg.mozilla.org/mozilla-central/rev/051041ba94d6bac70258746672ba5a731ac43b6d
[2] https://hg.mozilla.org/mozilla-central/rev/cad4365c7898c0bff7f68ed8ec50091cf8a63f47
|
|
Assignee | |
Comment 5•2 months ago
|
||
After [1], nsColumnSetFrame becomes the inner frame of ColumnSetWrapperFrame, so
we don't need to consider size containment for nsColumnSetFrame.
[1] https://hg.mozilla.org/mozilla-central/rev/62a41cc1264ebceedd1458b60f1c1500f0565794
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/03c849ad0b65 Part 1 - Clean up for InlineIntrinsicISizeData and related APIs. r=layout-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/ca4663492dd3 Part 2 - Clean up for InlineIntrinsicISizeData::FloatInfo. r=layout-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/b5c6ebf46a0e Part 3 - Delete GetMinISize/GetPrefISize overrides for BRFrame. r=layout-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/861949e8197b Part 4 - Remove obsolete comments in nsCheckboxRadioFrame. r=layout-reviewers,jfkthame https://hg.mozilla.org/integration/autoland/rev/7b89ac66d0b9 Part 5 - Remove obsolete comments in nsColumnSetFrame. r=layout-reviewers,jfkthame
|
||
Comment 7•1 month ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/03c849ad0b65
https://hg.mozilla.org/mozilla-central/rev/ca4663492dd3
https://hg.mozilla.org/mozilla-central/rev/b5c6ebf46a0e
https://hg.mozilla.org/mozilla-central/rev/861949e8197b
https://hg.mozilla.org/mozilla-central/rev/7b89ac66d0b9
Description
•