1909899 - Zooming on traces with only one DOM event is buggy

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Alexandre Poirot [:ochameau]]

When the trace displays a unique call tree, for example when tracing:
data:text/html,<script>window.onclick = foo; function foo() {}</script>

Zooming will quickly trigger the following exception:
can't access property "length", this.props.getChildren(...) is undefined
And before reaching this exception, the tree may display more than the expected number of elements.
This isn't trivial to spot without enabling the stdout logs of Tracer.js and looking at start and end indexes.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1909899 - [devtools] Ensure always rendering one trace when zooming on the end of the record.

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1909899 - [devtools] Fix zooming on the last traced call tree.

When zooming past the last top trace, i.e. on the last call tree,
we should be using the startIndex of unique top trace and nothing else.

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1909899 - [devtools] Do not show unexpected children in traces.

The end index is meant to be exclusing (while the start is inclusive)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5325ad7cd570
[devtools] Ensure always rendering one trace when zooming on the end of the record. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/20fb070ee3ca
[devtools] Fix zooming on the last traced call tree. r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/c15579c965d5
[devtools] Do not show unexpected children in traces. r=devtools-reviewers,nchevobbe

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/5325ad7cd570
https://hg.mozilla.org/mozilla-central/rev/20fb070ee3ca
https://hg.mozilla.org/mozilla-central/rev/c15579c965d5