1910034 - Debugger crashes at opening

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Not sure what was the state of my Debugger before, but this morning, when opening the Debugger, it instantly crashed.

Error:
TypeError: can't access property "length", r is undefined

React Component Stack:

    in Exceptions
    in Connect(Exceptions)
    in div
    in Editor
    in Connect(Editor)
    in div
    in main
    in div
    in div
    in SplitBox
    in div
    in div
    in SplitBox
    in AppErrorBoundary
    in div
    in App
    in Connect(App)
    in Provider
    in Provider

Stacktrace:

lineInner@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:2966
line@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:277
_buildDecorationsForMarker@resource://devtools/client/shared/sourceeditor/editor.js:804:42
updateDecorationsForAllMarkers@resource://devtools/client/shared/sourceeditor/editor.js:883:35
update@resource://devtools/client/shared/sourceeditor/editor.js:940:33
update@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:22755
applyTransaction/<@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:31323
tt@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:25475
kt@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:30513
applyTransaction@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:31291
get state@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:26945
update@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:169562
Bs/this.dispatchTransactions<@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:168450
dispatch@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:169233
removePositionContentMarker@resource://devtools/client/shared/sourceeditor/editor.js:1387:8
clearMarkers@resource://devtools/client/debugger/src/components/Editor/Exceptions.js:66:14
componentWillUnmount@resource://devtools/client/debugger/src/components/Editor/Exceptions.js:50:10
callComponentWillUnmountWithTimer@resource://devtools/client/shared/vendor/react-dom.js:12816:12
safelyCallComponentWillUnmount@resource://devtools/client/shared/vendor/react-dom.js:12824:40
commitUnmount@resource://devtools/client/shared/vendor/react-dom.js:13147:41
commitNestedUnmounts@resource://devtools/client/shared/vendor/react-dom.js:13178:18
unmountHostComponents@resource://devtools/client/shared/vendor/react-dom.js:13439:27
commitDeletion@resource://devtools/client/shared/vendor/react-dom.js:13498:26
commitAllHostEffects@resource://devtools/client/shared/vendor/react-dom.js:14142:25
commitRoot@resource://devtools/client/shared/vendor/react-dom.js:14344:9
completeRoot/<@resource://devtools/client/shared/vendor/react-dom.js:15731:15
unstable_runWithPriority@resource://devtools/client/shared/vendor/react.js:617:12
completeRoot@resource://devtools/client/shared/vendor/react-dom.js:15730:27
performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15659:21
performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24
performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14
requestWork@resource://devtools/client/shared/vendor/react-dom.js:15410:5
scheduleWork@resource://devtools/client/shared/vendor/react-dom.js:15224:16
enqueueSetState@resource://devtools/client/shared/vendor/react-dom.js:8192:17
Component.prototype.setState@resource://devtools/client/shared/vendor/react.js:328:16
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1412:16
notify@resource://devtools/client/shared/vendor/react-redux.js:1159:21
notifyNestedSubs@resource://devtools/client/shared/vendor/react-redux.js:1198:20
onStateChange@resource://devtools/client/shared/vendor/react-redux.js:1409:16
dispatch@resource://devtools/client/shared/vendor/redux.js:265:7
waitUntilService/</<@resource://devtools/client/debugger/src/actions/utils/middleware/wait-service.js:71:24
promiseMiddleware/</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:38:14
context/</<@resource://devtools/client/debugger/src/actions/utils/middleware/context.js:84:12
thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:100
dispatch@resource://devtools/client/shared/vendor/redux.js:681:28
promiseMiddleware/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/promise.js:57:15

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1910034 - [devtools] Fix issue in _buildDecorationsForMarker for marker.shouldMarkAllLines. r=bomsy.

With Bug 1909594, decorationLines items are expected to be an object.
We missed one callsite when marker.shouldMarkAllLines is true.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1909594

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b460b4658d0
[devtools] Fix issue in _buildDecorationsForMarker for marker.shouldMarkAllLines. r=bomsy,devtools-reviewers.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6b460b4658d0