Closed Bug 1910119 Opened 1 year ago Closed 1 year ago

[a11y] Touch target suggestion for search bar on Samsung A32

Categories

(Firefox for Android :: Toolbar, defect, P3)

All
Android
defect

Tracking

()

VERIFIED FIXED
137 Branch
Accessibility Severity s3
Tracking Status
firefox128 --- wontfix
firefox129 --- wontfix
firefox130 --- wontfix
firefox137 --- verified

People

(Reporter: vtamas, Assigned: rebecatudor273)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group2])

Attachments

(4 files, 1 obsolete file)

Preconditions

  • Have Google Accessibility Scanner installed.

Steps to reproduce

  1. Launch Fenix app and navigate to homepage
  2. Scan the homepage using the Accessibility scanner app.

Expected behavior

No suggestions are made.

Actual behavior

This item's height is 40dp. Consider making the height of this touch target 48dp or larger. A TouchDelegate with size 352dp x 47 dp has been detected for this item. Consider increasing the size of its hit Rect.

Device information

  • Firefox version: Firefox Nightly 130 (2024-07-26), Firefox 129 Beta 8 and Firefox 128.0.3
  • Android device model: Samsung A32
  • Android OS version: Android 13

Any additional information?

  • This issue is a device specific issue and reproduces only on Samsung A32.
See Also: → 1811629
Summary: a11y → [a11y] Touch target suggestion for search bar on Samsung A32
Assignee: nobody → rebecatudor273

Rebeca, the UX team is still reviewing the a11y issues about touch target sizes, so this bug isn't ready to be fixed yet.

Flags: needinfo?(rebecatudor273)
Priority: -- → P3
See Also: → 1889748

Thank you for letting me know Chris. Is anywhere where i could see the updates regarding the reviewing?

Flags: needinfo?(rebecatudor273) → needinfo?(cpeterson)
Whiteboard: [fxdroid][group2]

(In reply to Rebeca Tudor from comment #3)

Thank you for letting me know Chris. Is anywhere where i could see the updates regarding the reviewing?

You can add yourself to the CC list of bug 1816534.

Flags: needinfo?(cpeterson)

Triaging this bug as access-S3, because it's expected that interactive target areas are to be 48dp or larger to allow users with limited dexterity and users on the go to better target and tap controls (per WCAG 2.2 Level AAA Success Criteria 2.5.5 and 2.5.8 Target Size (Enhanced and Minimum)). More details could be found in BBC Accessibility guide.

As Rebeca has mentioned above, the size of the icon does not have to be the main source of the size increase, because having a visually empty but actually tappable (interactive) space around the search icon is included in the size calculation. Also, for the minimum compliance with WCAG 2.2 it would be acceptable to have the touch/interactive target area for the image button to be, let's say, 44 dp but the empty space between this touch area and any other interactive element to be 2 dp on each side (2+44+2 = 48).

Notes:

  1. Automatic tools would still likely be flagging it, but it won't be a WCAG 2.2 violation at the moment. But...
  2. Font resizing on an OS level does not increase size of image buttons, and larger targets are, in general, easier to use, so going beyond the basic compliance is always encouraged for better user experience across the board
Accessibility Severity: --- → s3

This issue is also reproducible on Firefox 131.0b9 with Xiaomi Pad5 (Android 13).

To fix the touch target issue from homepage search bar, the value of
TOOLBAR_WRAPPER_INCREASE_HEIGHT_DPS was increased to 5 because the issue appeared
only on some devices so it may be a rounded number problem.
For the search bar from browser page it was increased the tap area using touch
delegate.
And the changes in in fragment_home.xml are made to fix the text scaling
suggestion. To keep the same UI it was added a vertical padding of 6 because
the height of the search selector is fixed with value of 28.

To fix the touch target issue from homepage search bar, the value of
TOOLBAR_WRAPPER_INCREASE_HEIGHT_DPS was increased to 5 because the issue appeared
only on some devices so it may be a rounded number problem.

Attachment #9463174 - Attachment is obsolete: true

The issue presented in this comment by Adina has a different ticket (Bug 1945173) opened as it's a different issue than the initial one described in this ticket.

Pushed by rtudor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b4eab41ed5c6 [a11y]Fix touch target suggestion for search bar r=android-reviewers,petru
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch
Flags: qe-verify+

Verified as fixed on the latest Fenix Nightly 137.0a1 from PlayStore, on the Samsung A32 (Android 13), Xiaomi Mi8 Lite (Android 10), and Samsung Galaxy A14 (Android 14).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: