1910206 - `GPUAdapter.info` not present in JS

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P1)

Description

[Erich Gubler [:ErichDonGubler]]

This was changed in spec. upstream at gpuweb#4662, and Firefox needs to catch up.

Comment 1

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1910206 - feat(webgpu): add `GPUAdapter.info` member r=#webgpu-reviewers!

Comment 2

[Erich Gubler [:ErichDonGubler]]

NOTE: Applicable CTS test is webgpu:api,operation,adapter,info:adapter_info:*.

Comment 3

[beaufort.francois]

Hello Erich!
Out of curiosity, what is the status of this bug?

As you can see in https://groups.google.com/a/chromium.org/g/blink-dev/c/HxOgGf4NzQ4, the Chrome team is about to deprecate and remove the non-standard GPUAdapter requestAdapterInfo() method now that the GPUAdapter info attribute has been implemented in Chrome and Safari browsers.

Comment 4

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1910206 - chore(webgpu)!: remove `GPUAdapter.requestAdapterInfo` method r=#webgpu-reviewers!

Comment 5

[Erich Gubler [:ErichDonGubler]]

beaufort.francois: I've just submitted patches that I've confirmed locally to work with CTS updates, which are awaiting what I suppose will be a fast review. I'll land the first patch adding GPUAdapter.info. Once Chrome and/or Safari confirm the removal of GPUAdapter.requestAdapterInfo, I'll land the second patch, which should close out this issue.

Comment 6

[beaufort.francois]

Thank you for the quick fix!

GPUAdapter.requestAdapterInfo is now deprecated in Chrome (https://chromium-review.googlesource.com/c/chromium/src/+/5578020) and will be removed entirely in next milestone.
Safari has recently removed it (https://github.com/gpuweb/gpuweb/pull/4662#issuecomment-2338982367)

Comment 7

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1910206 - refactor(webgpu): rename `Adapter::mInfo` to `mInfoInner` r=#webgpu-reviewers!

This member will go away once GPUAdapter.requestAdapterInfo is
removed.

Comment 8

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1910206 - refactor(webgpu): make `AdapterInfo` a refcounted object r=#webgpu-reviewers!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce8839295b98
refactor(webgpu): rename `Adapter::mInfo` to `mInfoInner` r=webgpu-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/c4eb1f5d4f44
refactor(webgpu): make `AdapterInfo` a refcounted object r=webgpu-reviewers,webidl,saschanaz,smaug,nical
https://hg.mozilla.org/integration/autoland/rev/eb99617332f0
feat(webgpu): add `GPUAdapter.info` member r=webgpu-reviewers,webidl,saschanaz,nical

Comment 10

[Erich Gubler [:ErichDonGubler]]

Attachment: Bug 1910206 - chore(webgpu): warn on use of deprecated `GPUAdapter.requestAdapterInfo` r=#webgpu-reviewers!

@jimb and I thought this would be an important signal for users while we wait to land D222065.

Comment 11

[Phabricator Automation]

Comment on attachment 9424557 [details]
Bug 1910206 - chore(webgpu)!: remove GPUAdapter.requestAdapterInfo method r=#webgpu-reviewers!

Revision D222065 was moved to bug 1919119. Setting attachment 9424557 [details] to obsolete.

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ce8839295b98
https://hg.mozilla.org/mozilla-central/rev/c4eb1f5d4f44
https://hg.mozilla.org/mozilla-central/rev/eb99617332f0

Comment 13

[Erich Gubler [:ErichDonGubler]]

Attachment: WIP: Bug 1910206: but does `jj` work tho

This patch is a test of something rather unrelated to this bug. Sorry,
not sorry, I want jj to work with moz-phab! 😅

Comment 14

[Erich Gubler [:ErichDonGubler]]

Attachment: WIP: Bug 1910206: but does `jj` work tho

This patch is a test of something rather unrelated to this bug. Sorry,
not sorry, I want jj to work with moz-phab! 😅

Comment 15

[Erich Gubler [:ErichDonGubler]]

Attachment: WIP: Bug 1910206: but does `jj` work tho

This patch is a test of something rather unrelated to this bug. Sorry,
not sorry, I want jj to work with moz-phab! 😅

Comment 16

[Erich Gubler [:ErichDonGubler]]

Attachment: WIP: Bug 1910206: but does `jj` work tho

This patch is a test of something rather unrelated to this bug. Sorry,
not sorry, I want jj to work with moz-phab! 😅

Comment 17

[Erich Gubler [:ErichDonGubler]]

Attachment: WIP: Bug 1910206: but does `jj` work tho

This patch is a test of something rather unrelated to this bug. Sorry,
not sorry, I want jj to work with moz-phab! 😅

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04ec3c099674
chore(webgpu): warn on use of deprecated `GPUAdapter.requestAdapterInfo` r=webgpu-reviewers,jgilbert

Comment 19

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/04ec3c099674