1910209 - Improve the Fakespot suggestions engagement telemetry test

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Drew Willcoxon :adw]

I have a small patch to improve the Fakespot suggestions engagement telemetry test.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1910209 - Improve the Fakespot suggestions engagement telemetry test and use https URLs in more Suggest tests.

The main thing this does is add a task to the Fakespot engagement telemetry test
that triggers both a Fakespot and history result and then clicks the history
result. I want to make sure the Fakespot engagement event isn't incorrectly
recorded. (I thought it might be but it's not.)

This also has a bunch of changes from http to https. Lint made me change the
URLs in the Fakespot test to https, which was a problem for the AMP result since
QuickSuggestTestUtils.ampRemoteSettings() uses http URLs. So I went ahead and
updated that function plus the other ones and all the places that are affected.

The UrlbarUtils change makes UrlbarTestUtils.getDetailsOfResultAt
return the right URL for Fakespot results. No tests fail with this change and it
seems like the right thing to do anyway.

Depends on D217780

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/edd40fa188c5
Improve the Fakespot suggestions engagement telemetry test and use https URLs in more Suggest tests. r=daisuke

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/edd40fa188c5