1910320 - Crash in [@ RtlpFreeHeapInternal | RtlFreeHeap | CKnownFoldersFolder::_EnumFolders]

Status: RESOLVED DUPLICATE of bug 1904436

(Firefox :: Shell Integration, defect)

Description

[BugBot [:suhaib / :marco]]

Crash report: https://crash-stats.mozilla.org/report/index/7aa6033d-a1ec-45dd-8817-2c7bc0240710

Reason: STATUS_HEAP_CORRUPTION

Top 10 frames of crashing thread:

0  ntdll.dll  RtlReportFatalFailure  
1  ntdll.dll  RtlReportCriticalFailure  
2  ntdll.dll  RtlpHeapHandleError  
3  ntdll.dll  RtlpHpHeapHandleError  
4  ntdll.dll  RtlpLogHeapFailure  
5  ntdll.dll  RtlpFreeHeapInternal  
6  ntdll.dll  RtlFreeHeap  
7  windows.storage.dll  CKnownFoldersFolder::_EnumFolders  
8  windows.storage.dll  CKnownFoldersFolder::ParseDisplayName  
9  windows.storage.dll  CRegFolder::ParseDisplayName  

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-07-10
• Process type: Parent
• Is startup crash: No
• Has user comments: No
• Is null crash: No

Comment 1

[Andrew McCreight [:mccr8]]

Topmost Gecko frame is IsCurrentAppPinnedToTaskbarSync().

Comment 2

[Andrew McCreight [:mccr8]]

For another crash, the topmost Gecko frame is nsWindowsShellService::GetLaunchOnLoginShortcuts().
bp-34744160-ac91-4263-ba46-ddd140240726

Comment 3

[Nipun Shukla]

Thanks for reporting this. It looks like the crash you linked also points to IsCurrentAppPinnedToTaskbarSync() but it would make sense that GetLaunchOnLoginShortcuts() has the same signature as they're functionally the same, just looking in different folders. I'll bring this up in our team's triage meeting as that code has been present in some form for 2 years.

Comment 4

[Andrew McCreight [:mccr8]]

The Nightly crashes are all in the 20240725093133 build, so maybe this is another dupe of the crashes bug 1904436 got backed out for.

Comment 5

[Nipun Shukla]

That would also make sense. How long do you think it would make sense to monitor that as the cause before closing as a duplicate?

Comment 6

[Andrew McCreight [:mccr8]]

There's been about a week of builds since the crash so let's just dupe it over.