1910334 - 24.96 - 2.47% reload-inspector:content-process memory / reload-inspector:content-process objects-with-stacks + 8 more (Linux, Windows) regression on Fri July 26 2024

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance regression from push b109d9a3387c660b35628532b50911a3deaeb201. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
25%	reload-inspector:content-process memory	linux1804-64-qr		7,681,024.00 -> 9,597,952.00
22%	reload-inspector:content-process memory	linux1804-64-shippable-qr		7,827,456.00 -> 9,517,738.67
16%	reload-inspector:content-process memory	linux1804-64-tsan-qr		105,593,514.67 -> 122,878,293.33
8%	damp simple.inspector.reload.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	44.01 -> 47.52
5%	damp inspector.layout.open	windows11-64-shippable-qr	e10s fission stylo webrender	152.01 -> 159.03
4%	damp complicated.inspector.open.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	229.23 -> 238.08
3%	damp simple.inspector.open.DAMP	windows11-64-shippable-qr	e10s fission stylo webrender	155.48 -> 160.61
3%	reload-inspector:content-process objects-with-stacks	linux1804-64-shippable-qr		3,974.58 -> 4,074.67
2%	reload-inspector:content-process objects-with-stacks	linux1804-64-qr		3,974.33 -> 4,073.42
2%	reload-inspector:content-process objects-with-stacks	linux1804-64-tsan-qr		3,969.00 -> 4,067.00

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
11%	damp complicated.styleeditor.open.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	422.55 -> 375.48

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 1530

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826409

:artemmanusenkov, since you are the author of the regressor, bug 1826409, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

I'll have a look

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826409

Comment 4

[Dianna Smith [:diannaS]]

:nchevobbe any update on this by any chance?

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1910334 - [devtools] Cleanup references on ViewportSizeHighlighter destroy. r=#devtools-reviewers.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

The attached patch seems to revert some of the reload-inspector:content-process memory increase: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=9ed17d25f2e1fe658e805f0ef867aafaf23bda9e&newProject=try&newRevision=e9c72d2dba13d5ad039804d99c0ed02d25cf2ec7&framework=12&page=1&filter=inspector%3Acontent-process

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c0d04577a10
[devtools] Cleanup references on ViewportSizeHighlighter destroy. r=devtools-reviewers,bomsy.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2c0d04577a10

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nchevobbe, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox132 to wontfix.

For more information, please visit BugBot documentation.