1910352 - input.Key{Down,Up}Action value should not accept multiple characters

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Martin Pitt]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

I'm currently implementing the BiDi spec for our project and noticed a quirk wrt. input.perofrmActions() [1] with KeyDown/Up. The spec does not define what "value" can/should contain at all, so I filed [2] and got explained that it uses the same values as classical webdriver [3].

In the end that all works well with both Firefox and Chromium, but during my experiments I noticed that trying to send multiple characters in a single action like this:

actions=[
        {"type": "key", "id": "key-0", "actions": [
        {"type": "keyDown", "value": "a"},
        {"type": "keyUp", "value": "a"}
]}])

slightly misbehaves with Firefox.

[1] https://w3c.github.io/webdriver-bidi/#command-input-performActions
[2] https://github.com/w3c/webdriver-bidi/issues/757
[3] https://w3c.github.io/webdriver/#dfn-process-a-key-action

Actual results:

That action succeeds in Firefox, typing a literal "hello" into the website.

The webdriver spec [3] says:

If key is not a String containing a single unicode code point or grapheme cluster? return error with error code invalid argument.

So Firefox seems to ignore that part. This is not actually breaking anything that should work, just a quirk in the error handling.

Expected results:

In Chromium it fails as per the spec: bidi.WebdriverError: error: Invalid key value: hello

Comment 1

[James Graham [:jgraham]]

I'm mildly surprised that the rest of the code works, but the frontend should probably handle this; see the TODO in https://searchfox.org/mozilla-central/source/remote/shared/webdriver/Actions.sys.mjs#769-772

Comment 2

[Martin Pitt]

I didn't try may code points, but I did try \uE007 aka "Enter", and that works fine with Firefox 128.

Comment 3

[James Graham [:jgraham]]

Attachment: Bug 1910352 - Ensure keyUp/keyDown value it one grapheme cluster,

Return InvalidArgumentError if the action value for key actions is
not exactly one grapheme cluster long.

Supporting full grapheme clusters rather than just single codepoints
is marked as TODO in the spec, so add tentative tests for that.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b39c4bd4277c
Ensure keyUp/keyDown value it one grapheme cluster, r=webdriver-reviewers,jdescottes

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47508 for changes under testing/web-platform/tests

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/b39c4bd4277c

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot