1910373 - Crash in [@ java.lang.NullPointerException: at mozilla.components.feature.prompts.PromptFeature$onCancel$1.invoke(PromptFeature.kt)]

Status: VERIFIED FIXED

(Firefox for Android :: Browser Engine, defect)

Description

[Donal Meehan [:dmeehan]]

Crash report: https://crash-stats.mozilla.org/report/index/65f81f62-3edc-4ab5-a6e3-563ec0240729

Top 10 frames:

0  mozilla.components.feature.prompts.PromptFeature$onCancel$1  invoke  PromptFeature.kt:53
1  mozilla.components.feature.prompts.PromptFeatureKt  consumePromptFrom  PromptFeature.kt:68
2  mozilla.components.feature.prompts.PromptFeature  onCancel  PromptFeature.kt:20
3  mozilla.components.feature.prompts.PromptFeature$start$1$3  emit  PromptFeature.kt:293
4  mozilla.components.support.ktx.kotlinx.coroutines.flow.FlowKt$ifAnyChanged$$i...  emit  Emitters.kt:134
5  mozilla.components.feature.prompts.PromptFeature$start$1$invokeSuspend$$inlin...  emit  Emitters.kt:65
6  kotlinx.coroutines.flow.FlowKt__ChannelsKt  emitAllImpl$FlowKt__ChannelsKt  Channels.kt:129
7  kotlinx.coroutines.flow.FlowKt__ChannelsKt$emitAllImpl$1  invokeSuspend  Channels.kt:12
8  kotlin.coroutines.jvm.internal.BaseContinuationImpl  resumeWith  ContinuationImpl.kt:9
9  kotlinx.coroutines.DispatchedTask  run  DispatchedTask.kt:111

Crashes in Fx129 started in 129.0b9

Comment 1

[Donal Meehan [:dmeehan]]

:amejia could you take a look at this?
Bug 1908344 is the only change in 129.0b9 that pops out at me. The crashes in Fx130 line up with when this landed in central.
Could that be the regressor, or is it something else?

Comment 2

[Donal Meehan [:dmeehan]]

:royang, Arturo might be out this week based on his Slack status. If so, could you take a look?

Comment 3

[Arturo Mejia [:amejia]]

I was on PTO on Friday, taking a look!

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Browser Engine' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[Arturo Mejia [:amejia]]

Attachment: Bug 1910373 - Provide a value for shouldNotShowMoreDialogs when canceling popup

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bf8904513a2
Provide a value for shouldNotShowMoreDialogs when canceling popup r=android-reviewers,Roger

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0bf8904513a2

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:amejia, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Arturo Mejia [:amejia]]

Attachment: Bug 1910373 - Provide a value for shouldNotShowMoreDialogs when canceling popup

Original Revision: https://phabricator.services.mozilla.com/D217962

Comment 10

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: User will get a crash when entering a page with permission request and popup
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Enter a page with a permission request which also has a popup
• Risk associated with taking this patch: Low
• Explanation of risk level: The issue case could be only afecting a small portion of users
• String changes made/needed: n/a
• Is Android affected?: yes

Comment 11

[Arturo Mejia [:amejia]]

Attachment: poc.html

For simulating the crash this example file can be used.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/1e138cb6a606

Comment 13

[Vasilica Tamas (Android QA) [:vtamas]]

This issue is verified as fixed on Firefox Nightly 130 (2024-07-02) and Firefox RC 129 build 2 using a Lenovo Tab P11 Pro with Android 13, Samsung S24 with Android 14 and Google Pixel 8 with Android 14. The app didn't crashed using the link provided in Comment 11 neither during the regression session. Marking as Verified.