Closed Bug 1910401 Opened 4 months ago Closed 2 months ago

Enable more update tests once we have switched to using the NSWorkspace API to launch our callback apps (bug 1827651)

Categories

(Core :: Widget: Cocoa, defect, P3)

defect

Tracking

()

RESOLVED FIXED
132 Branch
Tracking Status
firefox132 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I have noticed that most of our disabled update tests can be turned on after bug 1827651 has landed. The last remaining disabled test, marAppInUseStageSuccessComplete_unix.js, seems to fail due to an invalid dir.app. The NSWorkspace API requires our mock .app bundles to be valid too. Many of them have been updated for bug 1827651 and I suspect that a similar change could be applied to marAppInUseStageSuccessComplete_unix.js as well.

Assignee: nobody → spohl.mozilla.bugs
Status: NEW → ASSIGNED

It looks like this was indeed a quick fix. New try run with all previously-disabled update tests enabled: https://treeherder.mozilla.org/jobs?repo=try&revision=df5be50a8df7bca18a29bb2e6f6fcd6ccf6beeff

Blocks: 1707753
Blocks: 1713329
Blocks: 1724579
Blocks: 1754931
Attachment #9416591 - Attachment description: Bug 1910401: Enable more update tests now that we are using the NSWorkspace API to launch callback apps on macOS (bug 1827651). r=#application-update-reviewers → Bug 1910401: Enable more update tests now that we are using the NSWorkspace API to launch callback apps on macOS (bug 1827651). r=nalexander

The severity field is not set for this bug.
:spohl, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(spohl.mozilla.bugs)
Severity: -- → S3
Flags: needinfo?(spohl.mozilla.bugs)
Priority: -- → P3
Pushed by spohl@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/70e66c057eec Enable more update tests now that we are using the NSWorkspace API to launch callback apps on macOS (bug 1827651).
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 132 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: