1910428 - Remove duplicate code in nsContainerFrame::ComputeAutoSize

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

See the patches for other clean up.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1910428 Part 1 - Remove an unused #define in nsCheckboxRadioFrame.cpp. r?#layout

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1910428 Part 2 - Convert BtlsISizeType to an enum class. r?#layout

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1910428 Part 3 - Remove unused nsSubDocumentFrame::ComputeAutoSize(). r?#layout

The only caller of nsIFrame::ComputeAutoSize(), including all the override
methods by derived classes, is nsIFrame::ComputeSize(). Because
nsSubDocumentFrame provides its own ComputeSize(), its ComputeAutoSize()
is never used. Therefore, it can be removed.

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1910428 Part 4 - Call nsIFrame::ComputeAutoSize() in nsContainerFrame::ComputeAutoSize(). r?#layout

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb5182a9ee92
Part 1 - Remove an unused #define in nsCheckboxRadioFrame.cpp. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/63b49033e0e6
Part 2 - Convert BtlsISizeType to an enum class. r=layout-reviewers,jfkthame
https://hg.mozilla.org/integration/autoland/rev/50868b2aff9a
Part 3 - Remove unused nsSubDocumentFrame::ComputeAutoSize(). r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/eb6a8166ab1e
Part 4 - Call nsIFrame::ComputeAutoSize() in nsContainerFrame::ComputeAutoSize(). r=layout-reviewers,jfkthame

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/eb5182a9ee92
https://hg.mozilla.org/mozilla-central/rev/63b49033e0e6
https://hg.mozilla.org/mozilla-central/rev/50868b2aff9a
https://hg.mozilla.org/mozilla-central/rev/eb6a8166ab1e