Need to install .js files in Mozilla's not GRE's component dir

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
16 years ago
14 years ago

People

(Reporter: ssu0262, Assigned: ssu0262)

Tracking

Trunk
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

4.72 KB, patch
sspitzer
: review+
dveditz
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
The following .js files need to be moved from the GRE's components dir to
Mozilla's components dir:

 bin\components\nsProgressDialog.js
 bin\components\nsHelperAppDlg.js
 bin\components\nsDownloadProgressListener.js

This needs to be done after bug 190560 is fixed.  I'll do a manual verification
that moving these .js files does not regress bug 190465.
(Assignee)

Comment 1

16 years ago
Created attachment 113115 [details] [diff] [review]
patch v1.0 (ns tree)
(Assignee)

Comment 2

16 years ago
Created attachment 113116 [details] [diff] [review]
patch v1.0 (moz tree)
(Assignee)

Updated

16 years ago
Attachment #113116 - Flags: superreview?(dveditz)
Attachment #113116 - Flags: review?(sspitzer)
(Assignee)

Updated

16 years ago
Attachment #113115 - Flags: superreview?(dveditz)
Attachment #113115 - Flags: review?(sspitzer)
Comment on attachment 113115 [details] [diff] [review]
patch v1.0 (ns tree)

r=sspitzer
Attachment #113115 - Flags: review?(sspitzer) → review+
Comment on attachment 113116 [details] [diff] [review]
patch v1.0 (moz tree)

r=sspitzer
Attachment #113116 - Flags: review?(sspitzer) → review+
(Assignee)

Comment 5

16 years ago
doug, chak, do you guys think this is a topembed bug since the download manager
still works and that bug 190560 is fixed?
Status: NEW → ASSIGNED

Comment 6

16 years ago
what .js files are being installed into the GRE?
(Assignee)

Comment 7

16 years ago
 bin\components\nsProgressDialog.js
 bin\components\nsHelperAppDlg.js
 bin\components\nsDownloadProgressListener.js

Comment 8

16 years ago
those files should exist in the application component directory.
Why the added chrome registration line? The existing registration of the parent
"content/communicator/" should cover it.
(Assignee)

Comment 10

16 years ago
I did not realize that.  Just noticed that it was missing when comparing against
the pregenerated installed-chrome.txt file.

I'll remove it before checkin it in.
Comment on attachment 113115 [details] [diff] [review]
patch v1.0 (ns tree)

This isn't needed
Attachment #113115 - Attachment is obsolete: true
Attachment #113115 - Flags: superreview?(dveditz) → superreview-
Comment on attachment 113116 [details] [diff] [review]
patch v1.0 (moz tree)

sr=dveditz on the package list changes, - on the extra chrome registration
Attachment #113116 - Flags: superreview?(dveditz) → superreview+
(Assignee)

Comment 13

16 years ago
just the moz patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 14

16 years ago
verified in mozilla 2003031108
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.