1910488 - Update moz-button's Storybook status to stable

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P3)

Description

[Tim Giles [:tgiles]]

We've been using moz-button without any major issues for a few months now, let's go ahead and update the status in Storybook so that developers feel more confident in using the component.

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help.
   This will tell others that you're working on the next steps.
2. Download and build the Firefox source code
   • Here is a more detailed tutorial for getting set up to work on Firefox
   • If you have any problems, please ask on Element/Matrix in the #introduction channel. They're there to help you get started.
3. Start working on this bug. You will need to change the status in the moz-button.stories.mjs file to "stable".
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #reusable-components channel on Element/Matrix most hours of most days.
4. Build your change with mach build and verify your change with mach storybook and navigating to the moz-button story to ensure the status is updated. Also check your changes for adherence to our style guidelines by using mach lint.
5. Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
   • How to Submit a Patch
   • This is when the bug will be assigned to you.
6. After a series of reviews and changes to your patch, I'll push it to autoland.
   • If there are changes requested, please read the "To update a submitted patch" section to ensure you don't accidentally create a duplicate revision!

Comment 1

[Jess Lark]

Volunteering to work on this bug

Comment 2

[Jess Lark]

Hi Tim, I am working on this change but I am stuck at the "submit a patch" stage.

• The default branch name is "bookmarks/central", is that correct?
• Do I make a new branch, commit, and push, using typical git commands?
• I tried doing that, and am not sure what my username/pw for https://hg.mozilla.org is
• Is there any kind of "making your very first patch to firefox" doc? I've read through a lot of the documentation but it seems to assume a level of background knowledge that I am missing.

Thanks!

Comment 3

[Jess Lark]

Attachment: Bug 1910488 - Update storybook button status from in-development to stable. r=tgiles

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee1ee20b75ca
Update storybook button status from in-development to stable. r=reusable-components-reviewers,hjones

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ee1ee20b75ca