1910555 - [wdspec] Resume blocked requests from the setup_blocked_request fixture on teardown

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

Our setup_blocked_request fixture will create a blocked request and it's up to the tests to handle them. However for invalid tests (and maybe others), we never actually unblock/resume the request, and it seems to lead to issues on macos debug, with too many open files.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1910555 - [wdspec] Resume blocked requests from the setup_blocked_request fixture on teardown

Hanging blocked requests lead to intermittent failures on mac os debug CI due to too many open files.
Updates the setup_blocked_request to fail requests (or cancel the auth for auth requests).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e0305e8f094
[wdspec] Resume blocked requests from the setup_blocked_request fixture on teardown r=webdriver-reviewers,whimboo

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47358 for changes under testing/web-platform/tests

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 9416746 [details]
Bug 1910555 - [wdspec] Resume blocked requests from the setup_blocked_request fixture on teardown

Beta/Release Uplift Approval Request

• User impact if declined: This only addresses relatively frequent failures on macos debug CI for late beta.
  It can either be uplifted or ride the trains.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Test only change for wdspec tests.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Donal Meehan [:dmeehan]]

:jdescottes beta is closed this week since Fx129 is now in RC.
This will ride the train to beta with Fx130.

Are the tests you were looking at also failing in release?
If so then I can change the uplift request for release.

Comment 6

[Julian Descottes [:jdescottes]]

(In reply to Donal Meehan [:dmeehan] from comment #5)

:jdescottes beta is closed this week since Fx129 is now in RC.
This will ride the train to beta with Fx130.

Are the tests you were looking at also failing in release?
If so then I can change the uplift request for release.

Not yet. I imagine it will be the case once 129 becomes the release channel, but it's not clear why we didn't have the issue for 128 or earlier. Those tests haven't really changed since 124. Do we have any beta as release simulations where I could retrigger the impacted jobs?

Comment 7

[Donal Meehan [:dmeehan]]

129 is already merged to release.
302 to :aryx about the simulations question

Comment 8

[Julian Descottes [:jdescottes]]

If I'm checking the right page https://treeherder.mozilla.org/jobs?repo=mozilla-release&searchStr=wd%2Cdebug&fromchange=34f042a77009bc036fb31cc5bdbfa591177dff18, then we never run wdspec tests in debug mode on the release channel, so I guess we won't have the issue. We don't seem to run much debug tests in general for release?

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9416746 [details]
Bug 1910555 - [wdspec] Resume blocked requests from the setup_blocked_request fixture on teardown

This will ride the train to beta with Fx130

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6e0305e8f094

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot