Open Bug 1910595 Opened 7 months ago Updated 7 months ago

Spike: Single Tap for Search

Categories

(Fenix :: Experimentation and Telemetry, task)

All
Android
task

Tracking

(Not tracked)

People

(Reporter: towhite, Assigned: towhite)

References

(Depends on 1 open bug)

Details

Investigate the following conditions when the cursor focused on URLbar with the keyboard up (This module should load before new tab):

  • On fresh App launch (including after first run onbaording)
  • When launching a new tab

See comment 2 for investigation into updated requirements.

Questions

  1. Does this need to work the new navigation bar? Yes

Note

On relaunching the app with tabs already open
When today it open to your previously active tab in focus, it should continue to do that, but with the keyboard up, and the urlbar in focus

⚠️ This is a new state for Fenix as the homepage is generally displayed in the ‘focused’ view. We may encounter unknown bugs

Findings

Using the original URL toolbar:

  • After first run on-boarding ✅ update focusOnAddressBar default to true nav_graph.xml
  • On App launch ✅ update focusOnAddressBar default to true nav_graph.xml
    • On Fresh app launch it should behave like new tab ✅ update focusOnAddressBar default to true nav_graph.xml
    • On relaunching the app with tabs already open
      • When today it open to your previously active tab in focus, it should continue to do that, but with the keyboard up, and the url bar in focus. ✅ Similar to HomeFragment, add a android:name="focusOnAddressBar"
  • When launching a new tab ✅ update focusOnAddressBar default to true nav_graph.xml
  • When clicking the home button in the taskbar ✅ update focusOnAddressBar default to true nav_graph.xml

Using the new navigation bar:

  • After first run on-boarding ✅ update focusOnAddressBar default to true nav_graph.xml. ⚠️ This affects the navbar CFR positioning
  • On App launch ✅ update focusOnAddressBar default to true nav_graph.xml
    • On Fresh app launch it should behave like new tab ✅ update focusOnAddressBar default to true nav_graph.xml
    • On relaunching the app with tabs already open
      • When today it open to your previously active tab in focus, it should continue to do that, but with the keyboard up, and the url bar in focus. ✅ Similar to HomeFragment, add a android:name="focusOnAddressBar"
  • When launching a new tab ✅ Already does this
  • When clicking the home button in the taskbar ✅ Already does this (this is a new tab + button)
Depends on: 1910889
No longer depends on: 1910394

Updated requirements

Expected 'focus' behaviour is consitent with the current app implementation, e.g. when cursor is focused on the URL bar the keyboard is up and displayed on top of the homescreen (This module should load before new tab).

Findings

Using the original URL toolbar:

  1. On fresh App launch (including after first run onbaording)
    1. ✅ update focusOnAddressBar safeArg for HomeFragment as defined in the nav_graph.xml.
  2. When launching a new tab
    1. ✅ Already does this

Using the new navigation bar:

  1. On fresh App launch (including after first run onbaording)
    1. ✅ Update focusOnAddressBar safeArg for HomeFragment as defined in the nav_graph.xml. ⚠️ This affects the navbar CFR positioning
  2. When launching a new tab
    1. ✅ Already does this
You need to log in before you can comment on or make changes to this bug.