1910637 - youtube lag when scroll

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[mix5003]

Attachment: Troubleshooting Information.txt

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:130.0) Gecko/20100101 Firefox/130.0

Steps to reproduce:

1. go to https://www.youtube.com/watch?v=QuW3yUaDhLI and config to 1080p (may be use theater mode too)
2. scroll up and down

VIDEO: https://www.youtube.com/watch?v=vFs6A5LstXI

Actual results:

scroll scroll it lag a little bit when video in viewport
and some framedrop

Expected results:

it should not lag when scroll with video in view port

Comment 1

[mix5003]

mozregression

Bug 1908585 - Disable overlay only for slow present video r=gfx-reviewers,lsalzman

The change disables video overlay only for the slow present video, instead of disabling overlay in system wide.

Disabling the overlay is decided by DCSurfaceVideo. And controlling overlay usage is done by AsyncImagePipelineManager. To deliver the decision, RenderTextureHostUsageInfo is used. RenderTextureHostUsageInfo is shared among, DCSurfaceVideo, RenderTextureHost, AsyncImagePipelineManager and WebRenderImageHost.

Then if RenderTextureHostUsageInfo::DisableVideoOverlay() is called by DCSurfaceVideo, AsyncImagePipelineManager could know if overlay is disabled for TextureHost by RenderTextureHostUsageInfo::DisableVideoOverlay().

WebRenderImageHost retains the RenderTextureHostUsageInfo returned by RenderTextureHost and reuses the returned RenderTextureHostUsageInfo. And if the video overlay is disabled, the disabled overlay is retained for the lifetime of WebRenderImageHost.

There is a case that RenderTextureHost::GetOrMergeUsageInfo() needs to merge 2 RenderTextureHostUsageInfos to one RenderTextureHostUsageInfo. It happens when one TextureHost is used by multiple WebRenderImageHosts.

Differential Revision: https://phabricator.services.mozilla.com/D217355

Comment 2

[Mayank Bansal]

Thanks for doing the bisection!

1. Can you paste the contents of about:support to this bug?
2. Capture a performance profile with the "graphics" preset when you see the lag/stutter. See this user guide : https://profiler.firefox.com/docs/#/./guide-getting-started

Comment 3

[mix5003]

Attachment: about:support

from mozregression run single build at 2024-07-30
graphics Profile link: https://share.firefox.dev/3ynfzft
media profile link: https://share.firefox.dev/4c5M53z  (just in case)

about:support

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: WebRender' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to mix5003 from comment #3)

from mozregression run single build at 2024-07-30
graphics Profile link: https://share.firefox.dev/3ynfzft
media profile link: https://share.firefox.dev/4c5M53z (just in case)

Confirmed from the profile that slow present tried to disable video overlay of hardware decoded video, but the overlay was not disabled.

Comment 6

[Sotaro Ikeda [:sotaro]]

There is a 2 places to disable video overlays.

• DCLayerTree::CompositorEndFrame()
• DCSurfaceVideo::PresentVideo()

I forgot to add calling DCSurfaceVideo::DisableVideoOverlay() in DCSurfaceVideo::PresentVideo() :(

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1910637 - Call DisableVideoOverlay() in DCSurfaceVideo::PresentVideo() if necessary

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c1da05983f
Call DisableVideoOverlay() in DCSurfaceVideo::PresentVideo() if necessary r=gfx-reviewers,lsalzman

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/a3c1da05983f

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1908585

Comment 11

[Sotaro Ikeda [:sotaro]]

Hi mix5003, does the problem addressed with latest nightly?

Comment 12

[mix5003]

i think latest nightly fixed this problem. Thanks

Comment 13

[Sotaro Ikeda [:sotaro]]

Great! Thank you for checking.