1910686 - Remove support for the assert syntax

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Jonatan Klemets [:jon4t4n]]

The assert syntax was removed from the spec today [1] and has also been unshipped in Chrome 126.

We should remove the code that handles the assert syntax and its associated pref (javascript.options.experimental.import_attributes.assert_syntax).

[1] https://github.com/tc39/proposal-import-attributes/pull/161

Comment 1

[Dan Minor [:dminor]]

Thanks for filing the bug :)

Comment 2

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1910686 - Part 1: Update tests using the old assert syntax and flag r=#spidermonkey-reviewers

The --enable-import-assertions flag and the support for the assert syntax
will be removed, so we need to update a few old test cases to use the new
with syntax and also the correct flag.

Comment 3

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1910686 - Part 2: Remove old import-assertions SHELL_OPTIONS from test262-update.py r=#spidermonkey-reviewers

This patch removes an old unused flag. The tests for the assert syntax were
removed in PR 4203 [1] and were imported into central as part of bug 1919446
[2].

[1] https://github.com/tc39/test262/pull/4203
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1919446

Comment 4

[Jonatan Klemets [:jon4t4n]]

Attachment: Bug 1910686 - Part 3: Remove import assertions implementation r=#spidermonkey-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fccb79317a0f
Part 1: Update tests using the old assert syntax and flag r=spidermonkey-reviewers,mgaudet
https://hg.mozilla.org/integration/autoland/rev/53da75056e57
Part 2: Remove old import-assertions SHELL_OPTIONS from test262-update.py r=spidermonkey-reviewers,mgaudet
https://hg.mozilla.org/integration/autoland/rev/c80207436547
Part 3: Remove import assertions implementation r=spidermonkey-reviewers,mgaudet

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fccb79317a0f
https://hg.mozilla.org/mozilla-central/rev/53da75056e57
https://hg.mozilla.org/mozilla-central/rev/c80207436547