1910715 - Sidebar search background sometimes indistinguishable on dark themes

Status: RESOLVED DUPLICATE of bug 1920902

(Firefox :: Sidebar, enhancement)

Description

[Nikki Sharpley (:nikkis) (she/her)]

Styling covered in Bug 1886847 required the search input to have a --toolbar-field-background-color.

Previously, this was fixed by the below, but we could stand to find a better solution with more optimal variables.

  @media (prefers-color-scheme: dark) {
    &::part(input) {
      background-color: var(--toolbar-bgcolor);
      color: var(--toolbar-color);
    }
  }

Comment 1

[Kestrel]

Attachment: Sidebar search box lacks contrast with System theme (light)

The System theme (light) is also affected on Ubuntu 24.04. The sidebar search box only has contrast with Light theme or System theme (light) + private windows (dark).

Comment 2

[Kestrel]

The System theme (light/dark) is no longer affected on Ubuntu 24.04.

Fix window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a943bc4efb5cc72df1eb2777d71c69e79e258c1e&tochange=1e5c8cd5f3868570ac719e3c0edcd95b4ed368cd

Fixed by Bug 1916101.

The Dark theme is still affected.

Comment 3

[Sarah Clements [:sclements]]

I think this will be fixed by bug 1920902.