Closed Bug 1910758 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 47367 - [layout] Support min-block-size/max-block-size min-content/etc in flex

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
130 Branch
Tracking Flags:
Tracking Status
firefox130 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 47367 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47367
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[layout] Support min-block-size/max-block-size min-content/etc in flex

This patch adds support for things like "max-height: min-content"
within the flex sizing algorithm.

We introduce variants of ResolveMinBlockLength/etc which accept a
function-ref to resolve min-content/etc when required.

We somewhat supported this previously (see previous logic in
ShouldApplyMinSizeAutoForChild), but it wasn't complete.

Bug: 40151761
Change-Id: Ib9f70e70d73732e3694598653d6517619e561454
Reviewed-on: https://chromium-review.googlesource.com/5744698
WPT-Export-Revision: 0d5c72d0e902beae5b515bf8a700a4b48b03fbc5

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 2
FAIL: 2

Chrome

PASS: 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d71662e285a7 [wpt PR 47367] - [layout] Support min-block-size/max-block-size min-content/etc in flex, a=testonly https://hg.mozilla.org/integration/autoland/rev/693eceb9eb6c [wpt PR 47367] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d71662e285a7
https://hg.mozilla.org/mozilla-central/rev/693eceb9eb6c

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox130: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 130 Branch
You need to log in before you can comment on or make changes to this bug.