1910807 - PiP captions no longer work in arte.tv

Status: VERIFIED FIXED

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[kpatenio]

STR:

1. View a video in www.arte.tv (example video)
2. Enable captions in the site's video player
3. Enable PiP for the video via the address bar button, toggle over the video, or context menu

Expected:

• captions are displayed on the PiP window

Actual:

• no captions are displayed on the PiP window

Notes:

• Our initial wrapper https://searchfox.org/mozilla-central/source/browser/extensions/pictureinpicture/video-wrappers/arte.js no longer works. Looks like arte now uses videojs.

Comment 1

[Albert Scheiner [:alberts]]

And there I was, thinking the video I am watching was missing some tranalations haha

Confirmed. Captions are only displayed in main tab.

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1910807 - Use videoJS wrapper for Arte PiP captions. r?kpatenio

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/310dc42a3cd0
Use videoJS wrapper for Arte PiP captions. r=kpatenio

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/310dc42a3cd0

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:evilpie, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Albert Scheiner [:alberts]]

Seems to work fine. Tested with: https://www.arte.tv/de/videos/116059-009-A/twist/ (seems to have no geolocation restriction, and has a subtitle)

Comment 7

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue on an affected Nightly 130.0a1 build from 2024-07-30, using Windows 11, while following the steps from Comment 0.
Verified as fixed with Firefox 132.0b5, on macOS 14.6, Windows 11 and Ubuntu 22.04. PiP captions work in arte.tv.