1910868 - [GPU-canvas] Testcase from bug 1828940 doesnt animate with gpu-canvas

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect, P2)

Description

[Mayank Bansal]

Use latest nightly on windows. This shpuld have gpu-canvas enabled
Open the testcase from bug 1828940 (https://bugzilla.mozilla.org/attachment.cgi?id=9329296)

AR: The green thing stops after a second
ER: The whole red box should have been covered by the green thing

Additional steps: Each time you reload the testcase, the green thing moves a little further as if it remembers its previous position.

Bisection:
Bug 1829026 - Handle KERN_ABORTED from semaphore_wait. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D195952

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Attachment: tc-1828321.html

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1829026

:lsalzman, since you are the author of the regressor, bug 1829026, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 4

[Bob Hood [:bhood]]

Mayank, does disabling Accelerated Canvas2D (gfx.canvas.accelerated) in about:config fix the issue?

Comment 5

[Mayank Bansal]

Yes.

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Bug 1910868 - Copy Path state if DrawTarget backend type does not match. r?aosmond

When we fallback from accelerated canvases to non-accelerated canvases, there may
be a stale PathRecording left around that DrawTargetSkia can't use. In this case,
we need to create a PathSkia with the PathRecording's contents.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9a427160a76
Copy Path state if DrawTarget backend type does not match. r=aosmond

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a9a427160a76

Comment 10

[Mayank Bansal]

This is fixed for me on the latest Nightly

Comment 11

[Donal Meehan [:dmeehan]]

:lzlazman is this needed in Fx130, do you want to add a beta uplift request?

Comment 12

[Lee Salzman [:lsalzman]]

I would rather let this ride the trains.

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-07-31 Nightly build on Windows 10 using the testcase from Comment 2.
Verified as fixed on Firefox 131.0b5 and Firefox Nightly 132.0a1 on Windows 10, Ubuntu 22, macOS 14.
However, it’s worth mentioning that on Windows 10 on both Fx 131.0b5 and Nightly 132.0a1 the animation takes longer to fully render compared to macOS/Ubuntu.
Is this expected or should I file a follow-up bug for Windows-only??
Thank you.

Comment 14

[Lee Salzman [:lsalzman]]

Windows and Linux/macOS use different acceleration systems, so it's expected.

Comment 15

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Thank you for the confirmation!
Removing the qa-verify+ flag and updating the bug.