191087 - process_bug.cgi: "Mid-air collision!" title when not allowed to change a field

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Tobias Burnus]

Mid-air collision!

 You tried to change the priority field from P2 to P3, but only the owner or   
 submitter of the bug, or a sufficiently empowered user, may change that field.

The message is in user-error.html.tmpl "illegal_change"
and "Mid-air collision!" is in ./bug/process/header.html.tmpl
[% ELSIF title_tag == "mid_air" %]
  [% title = "Mid-air collision!" %]
[% END %]

I have no idea why this is set, but a fix would be
   [% ELSIF error == "illegal_change" %]
+    [% title = "Not allowed" %]
in global/user-error.html.tmpl

Comment 1

[Gervase Markham [:gerv]]

A fix is, as burnus suggests, to add a [% title = "" %] in the error message
clause in user-error.html.tmpl. But that doesn't quite explain how title_tag got
set to "mid_air" when an error was thrown. Perhaps the error is thrown partway
through the process when we have already determined that there's a mid-air?

Further investigation is required.

Gerv

Comment 2

[Tobias Burnus]

Attachment: Add a title and fix warning.

> Perhaps the error is thrown partway through the process when we have already
> determined that there's a mid-air?
This seems to be the case, but it I don't think someone else committed
something, so it must be me playing with things which I may not change. I saw
it again, but I cannot really reproduce it, so just ignore it.

I added now a title to user-error.html.tmpl and fixed the call of
get_component_name (takes one argument, so it showed als old one always the
component with the id = produce_it!)

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 113026 [details] [diff] [review]
Add a title and fix warning.

r=gerv.

Gerv

Comment 4

[Tobias Burnus]

My patch => (re)assign to me ;-)

Comment 5

[Tobias Burnus]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.173; previous revision: 1.172
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.28; previous revision: 1.27
done