1911019 - [GPU-Canvas] MinorGC markers are not visible on a profile

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect, P2)

Description

[Mayank Bansal]

Open https://share.firefox.dev/4fpfFnx

AR: The yellow colored minorGC markers are not visible on the "Memory" track
ER: They shoudl be visible.

Regressed by: bug 1910138

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1910138

:lsalzman, since you are the author of the regressor, bug 1910138, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Mayank Bansal]

Attachment: Bug.png

Comment 4

[Mayank Bansal]

With gpu-canvas manually enabled, bisection:

Bug 1874314 - Better anti-aliasing for subpixel rectangles. r=aosmond

The existing distance-to-edge AA scheme breaks down somewhat when rectangles
have subpixel areas. We need to bias the AA to account for this situation when
the scales get to these subpixel sizes.

Differential Revision: https://phabricator.services.mozilla.com/D215095

Comment 5

[Lee Salzman [:lsalzman]]

Attachment: Bug 1911019 - Use different anti-aliasing approximation for subpixel rectangles. r?aosmond

The previous attempt at refining the subpixel anti-aliasing approximation modified the
distance-to-edge tracking, which can cause the AA to approach zero too soon.

This fixes this by reverting the distance-to-edge tracking back to the way it was, but
instead limiting the alpha to the area of the subpixel rectangle if necessary.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f19c35b800f5
Use different anti-aliasing approximation for subpixel rectangles. r=aosmond

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/f19c35b800f5

Comment 8

[Mayank Bansal]

This is fixed for me on the latest Nightly

Comment 9

[Lee Salzman [:lsalzman]]

Comment on attachment 9417622 [details]
Bug 1911019 - Use different anti-aliasing approximation for subpixel rectangles. r?aosmond

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Rendering artifacts in Canvas2D.
• User impact if declined: Rendering artifacts in Canvas2D.
• Fix Landed on Version: 130
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Seems stable in nightly.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9417622 [details]
Bug 1911019 - Use different anti-aliasing approximation for subpixel rectangles. r?aosmond

Approved for 128.2esr.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/a2a21e812f68