1911022 - Drag-and-drop of (large amount of) text on address bar causes 7s hang on the parent process

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mayank Bansal]

STR:

1. Open the attached testcase in the browser
2. Select all the text (Ctrl+A) and then drag-and-drop the selected text to the address bar

AR: The whole browser freezes (for 7 seconds)
ER: Not so

Profile: https://share.firefox.dev/3LJu4xg

Bisection:
Bug 1841869 - entering "abc @xyz.[TLD]" in address bar opens a prompt regarding loading "xyz.[TLD]" instead of searching for "abc @xyz.[TLD]" on the default search engine.r=adw

Differential Revision: https://phabricator.services.mozilla.com/D198196

Comment 1

[Mayank Bansal]

Attachment: about:support

Comment 2

[Mayank Bansal]

Attachment: test1.html

Comment 3

[Mayank Bansal]

Maybe the regex used in the regressor bug needs to be more specialized? Or an upper bound is needed on the total time spent in searching? Or not do the search in parent process at all.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1841869

Comment 5

[Marco Bonardo [:mak]]

The regex should definitely be applied to a partial string, or more specialized.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1841869

Comment 7

[Bas Schouten (:bas.schouten)]

The Performance Impact Calculator has determined this bug's performance impact to be medium. If you'd like to request re-triage, you can reset the Performance Impact flag to "?" or needinfo the triage sheriff.

Platforms: [x] Windows [x] macOS [x] Linux
Impact on browser: Causes noticeable jank
Configuration: Rare
[x] Able to reproduce locally

Comment 8

[Moritz Beier [:mbeier]]

Attachment: Bug 1911022 - Fix drag-and-drop of large amount of text on address bar causing hang on the parent process. r?mak

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1eacfd66dfd
Fix drag-and-drop of large amount of text on address bar causing hang on the parent process. r=mak

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/e1eacfd66dfd

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-12-12 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 135.0a1 on Windows 10, Ubuntu 22, macOS 14.