1911195 - New wpt failures in /css/css-viewport/ [width.html, zoom/border-spacing.html, zoom/letter-spacing.html, and 6 others]

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 47411 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

• /css/css-viewport/zoom/text-underline-offset.html [wpt.fyi]: FAIL

New Tests That Don't Pass

• /css/css-viewport/width.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-viewport/zoom/border-spacing.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-viewport/zoom/letter-spacing.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-viewport/zoom/line-height.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-viewport/zoom/text-indent.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-viewport/zoom/text-shadow.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-viewport/zoom/text-stroke-width.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /css/css-viewport/zoom/word-spacing.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1911169 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1911195 - patch 1 - Provide a zoom() method for various value types that may need to account for CSS zoom. r=#style

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1911195 - patch 2 - Apply zoom to more properties that contain <length> values. r=#style

This addresses only the properties that are currently covered by WPT testcases
in the css/css-viewport/zoom/ directory. To extend it to all <length>-valued
properties, we should arrange to generate the code rather than hand-maintain
a list of all the properties to be handled.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1911195 - patch 3 - Move cascade.rs into mako, and use a mako template to simplify zoomable-property handling. r=#style

This makes the code a bit less verbose, but still depends on an explicit list of the
properties to be processed, so only the WPT-tested properties are handled here.

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1911195 - patch 4 - Remove failure annotations for WPT zoom tests that now pass. r=#style

Comment 5

[Jonathan Kew [:jfkthame]]

The patches above just extend the font-size handling to cover the other properties tested in css-viewport/zoom, and pass the tests included in interop-2025.

Generalizing the code to handle all inherited properties, and generating it from the underlying property data rather than a manually-curated list of properties to process, is left as a followup for bug 1887627.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1911195 - Introduce infrastructure to re-cascade implicitly inherited zoom-dependent properties if needed. r=jfkthame,#style

This is infrastructure for a more generic version of bug 1911195. It
doesn't fix everything because:

• We still have an if is_unset { return; } in cascade.rs which we need
  to deal with. That means that we don't deal with explicit inherit.
  Note that was the case with the other bug afaict.

• It still doesn't automatically derive the length dependency, relying
  on a list in data.py.

The general approach is basically taking the inherited computed value
from the parent, but instead of just copying it blindly we re-compute it
with the specified zoom. This is handled only in cascade.rs, via
overriding the effective_zoom (arguably a bit hacky, but does the
trick).

I think in general it's a much cleaner approach, and fairly easy to
extend to explicit inheritance and non-inherited properties (for things
like e.g. width: inherit we need to do the same).

Comment 7

[Phabricator Automation]

Comment on attachment 9490608 [details]
Bug 1911195 - Introduce infrastructure to re-cascade implicitly inherited zoom-dependent properties if needed. r=jfkthame,#style

Revision D251121 was moved to bug 1968431. Setting attachment 9490608 [details] to obsolete.

Comment 8

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1911195 - Include a bunch more value types in zoom handling. r=#style

This extends the mechanism introduced in bug 1968431 to recognize more types
that involve a <length> component, and resolves the relevant interop-2025
test failures.

To properly finish bug 1887627, the manually-created, incomplete list of
types here should be replaced by something automatically derived from the
property data.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46864e758d22
Include a bunch more value types in zoom handling. r=firefox-style-system-reviewers,emilio

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/46864e758d22