1911216 - Add CSS selector parsing support for view transitions pseudo-elements

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Boris Chiou [:boris]]

Add the parser for the following pseudo elements:

1. ::view-transition
2. ::view-transition-group(name)
3. ::view-transition-image-pair(name)
4. ::view-transition-old(name)
5. ::view-transition-new(name)

Note that only ::view-transition is not functional. Others take a <pt-name-selector> as their argument (i.e. root or view-transition-name): <pt-name-selector> = '*' | <custom-ident>

The related wpt: testing/web-platform/tests/css/css-view-transitions/parsing/pseudo-elements-valid.html

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1911216 - Part 1: Add CSS selector parsing support for view transition pseudo-elements.

This adds the pasring support for:

1. ::view-transition
2. ::view-transition-group(name)
3. ::view-transition-image-pair(name)
4. ::view-transition-old(name)
5. ::view-transition-new(name)

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1911216 - Part 2: Support :only-child for view transition selectors.

We only accept :only-child pseudo class after a view transition pseudo
element. Other non-functional pseudo classes are not allowed. So add a special
case in the parser.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab49025245f3
Part 1: Add CSS selector parsing support for view transition pseudo-elements. r=layout-reviewers,firefox-style-system-reviewers,emilio,devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/2a950d7be993
Part 2: Support :only-child for view transition selectors. r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/47948 for changes under testing/web-platform/tests

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ab49025245f3
https://hg.mozilla.org/mozilla-central/rev/2a950d7be993

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot