1911353 - Reject `!important` declaration for `@position-try` like `@keyframes` does

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[David Shin[:dshin]]

(As part of https://phabricator.services.mozilla.com/D217629)
For the reference: https://searchfox.org/mozilla-central/rev/7279a1df13a819be254fd4649e07c4ff93e4bd45/servo/components/style/stylesheets/keyframes_rule.rs

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1911353 - Unify how we reject !important in keyframe and @position-try. r=dshin,#style

This was more the kind of thing I meant, and allows us to get rid of the
keyframe-rule-specific parser.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I mostly meant to unify in the opposite direction, see comment 1, fwiw :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6e3cddaa98e
Unify how we reject !important in keyframe and @position-try. r=dshin

Comment 4

[Narcis Beleuzu [:NarcisB]]

Backed out for Bp bustages on ServoStyleSet.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/0693f25185c1ead66a0744f27f474b2a9f26567e
Log link: https://treeherder.mozilla.org/logviewer?job_id=469399039&repo=autoland&lineNumber=99698

There were also mochitest failures on test_bug1112014.html.
Log link: https://treeherder.mozilla.org/logviewer?job_id=469409401&repo=autoland&lineNumber=3860

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Bustage is a missing include for non-unified builds from a previous bug, David can you fix it up? :)

The mochitest failures need investigation... Feel free to land without my patch and bounce the ni? back if it's caused by this one :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e19f73882313
Unify how we reject !important in keyframe and @position-try. r=dshin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b9736adb226
Unify how we reject !important in keyframe and @position-try. r=dshin

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3b9736adb226