1911384 - Update design for "desktop bookmarks" according to sync state

Status: RESOLVED FIXED

(Firefox for Android :: Bookmarks, enhancement)

Description

[Matt Tighe [:matt-tighe]]

While signed into sync, we should update the design for desktop bookmarks according to the spec.

If not signed in, we should stop displaying the desktop bookmark folders. (see comment)

If not signed in AND desktop bookmarks are empty, we should stop displaying the desktop bookmark folders.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

If not signed in, we should stop displaying the desktop bookmark folders.

Should this be something like "If not signed in and the desktop folder are empty"? I'm thinking of the case when a user signs out of Sync, so does have bookmarks in those folders.

Comment 2

[Matt Tighe [:matt-tighe]]

Really excellent point! I hadn't realized those bookmarks would be retained when a user signed out of sync. Thanks for popping in!

Comment 3

[Jeff Boek [:boek]]

Attachment: Bug 1911384 - Adds ability to laod desktop folders on SelectFolderAction.ViewAppeared

Comment 4

[Jeff Boek [:boek]]

Attachment: Bug 1911384 - Creates special view for the Desktop Root folder

Depends on D223600

Comment 5

[Jeff Boek [:boek]]

Attachment: Bug 1911384 - Conditionally load desktop folders and bookmarks when loading a folder

Depends on D223601

Comment 6

[Jeff Boek [:boek]]

Attachment: Bug 1911384 - Prevent creating a new folder from desktop root

Depends on D223602

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4c6d86a30dd
Adds ability to laod desktop folders on SelectFolderAction.ViewAppeared r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/42a918ff3618
Creates special view for the Desktop Root folder r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/ab0ed2f04bf1
Conditionally load desktop folders and bookmarks when loading a folder r=android-reviewers,matt-tighe
https://hg.mozilla.org/integration/autoland/rev/fe30b512dd19
Prevent creating a new folder from desktop root r=android-reviewers,matt-tighe

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a4c6d86a30dd
https://hg.mozilla.org/mozilla-central/rev/42a918ff3618
https://hg.mozilla.org/mozilla-central/rev/ab0ed2f04bf1
https://hg.mozilla.org/mozilla-central/rev/fe30b512dd19