1911489 - Consider to remove PlacesCompletionCallback

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement)

Description

[Daisuke Akatsuka (:daisuke)]

This is a follow-up of bug 1910338.
PlacesCompletionCallback had been used by only PlacesUIUtils to change the behavior by failure though, the code was no longer used in D218040. Several tests use it, but those look like replaceable with waitForNotification.
However, as it is the only way to detect failure while processing in nsIFaviconService.setFaviconForPage, we need to keep it for now.
In this bug, we introduce another way to detect failure (perhaps, using Promise that will be returned?), and remove the callback.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1911489: Make nsIFaviconService.setFaviconForPage() returns Promise

Depends on D218736

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1911489: Remove PlacesCompletionCallback

Depends on D218737

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6badc2766d0f
Make nsIFaviconService.setFaviconForPage() returns Promise r=places-reviewers,migration-reviewers,home-newtab-reviewers,nbarrett,mconley,mak,yazan
https://hg.mozilla.org/integration/autoland/rev/1f24313b74af
Remove PlacesCompletionCallback r=places-reviewers,mak

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ FaviconHelpers.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/d5ed7fdcd1c3fbfc4329bb4ffd3878da385bfe95

Push with failures

Failure log -> ERROR - /builds/worker/workspace/obj-build/dist/include/nsProxyRelease.h:271:7: error: member access into incomplete type 'mozilla::dom::Promise'

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f287f51804e9
Make nsIFaviconService.setFaviconForPage() returns Promise r=places-reviewers,migration-reviewers,home-newtab-reviewers,nbarrett,mconley,mak,yazan
https://hg.mozilla.org/integration/autoland/rev/1cd2917a3e0b
Remove PlacesCompletionCallback r=places-reviewers,mak

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/f287f51804e9
https://hg.mozilla.org/mozilla-central/rev/1cd2917a3e0b

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7fae8fb5987b
Adjust Thunderbird code for "Make nsIFaviconService.setFaviconForPage() returns Promise". rs=bustage-fix