Closed Bug 1911510 Opened 2 months ago Closed 2 months ago

Turn InplaceEditor cssVariables (Map) option into getCssVariables (Function) so it's only called when needed

Categories

(DevTools :: Shared Components, task)

task

Tracking

(firefox131 fixed)

RESOLVED FIXED
131 Branch
Tracking Status
firefox131 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

In the Rules view, we go through the existing Maps for CSS variables to pass it to the inplace editor. Doing it upfront is costly, especially since we might need to create new Maps.
Turning the option into a function will allow "lazy loading" the CSS variable list.

Change the cssVariables option, a Map, into getCssVariables, a function,
so it can be called only when it's needed.

Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f8794323217a [devtools] Lazy load cssProperties in InplaceEditor. r=devtools-reviewers,bomsy.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a33c19383e54 [devtools] Lazy load cssProperties in InplaceEditor. r=devtools-reviewers,bomsy.
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 131 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: