1911682 - [wpt-sync] Sync PR 47468 - [layout] Support min-height:min-content in more general case.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47468 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47468
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[layout] Support min-height:min-content in more general case.

This patch implements min-height:min-content (and friends)for all
other layout modes (we already have this for flex, replaced, and
abspos).

This does this by passing the BlockSizeFunc lambda into our
ComputeMinMaxBlockSizes function.

Bug: 40151761
Change-Id: I2cec527a69a6d03cbea989d75e9621b3db1817d0

Reviewed-on: https://chromium-review.googlesource.com/5754962
WPT-Export-Revision: 6daa5ce7a6ab70b55d904220ca50948f6645dd19

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa7013ccc04f2496d2900aa227d60caf890466aa

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 6 tests

Status Summary

Firefox

FAIL: 6

Chrome

FAIL: 6

Safari

PASS: 2
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-sizing/block-size-with-min-or-max-content-2.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-sizing/block-size-with-min-or-max-content-3.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-sizing/block-size-with-min-or-max-content-4.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-sizing/block-size-with-min-or-max-content-5.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-sizing/hori-block-size-small-or-larger-than-container-with-min-or-max-content-1.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-sizing/vert-block-size-small-or-larger-than-container-with-min-or-max-content-1.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9da7e0de2519
[wpt PR 47468] - [layout] Support min-height:min-content in more general case., a=testonly
https://hg.mozilla.org/integration/autoland/rev/57cedd7d22f3
[wpt PR 47468] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/9da7e0de2519
https://hg.mozilla.org/mozilla-central/rev/57cedd7d22f3