191169 - Duplicate accesskey "h" in proxies preferences

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[piers]

"HTTP Proxy" currently uses "h" as the accesskey which is reserved for the Help
button.

Comment 1

[piers]

Attachment: Change accesskey from h to x

HTTP Proxy

Can't use H, reserved for Help
Can't use T, P, R or O, reserved for one of the Ports

Comment 2

[:deanis74]

Comment on attachment 113004 [details] [diff] [review]
Change accesskey from h to x

I guess.  We can't remove H from Help because that's pretty standard
throughtout the app.  We can't steal the Port accesskeys because there's not
much choice for those.	The only other thing I can think of is toasting the
accesskeys on the Port fields altogether, and then the user can tab to them. 
But that's out of the scope of this bug.

r=me

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 113004 [details] [diff] [review]
Change accesskey from h to x

sr=dmose, assuming aaronl is ok with this change

Comment 4

[Aaron Leventhal]

Looks good to me - thanks Piers

Comment 5

[Robert Kaiser]

Checking in
mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-proxies.dtd;
/cvsroot/mozilla/xpfe/components/prefwindow/resources/locale/en-US/pref-proxies.dtd,v
 <--  pref-proxies.dtd
new revision: 1.22; previous revision: 1.21
done

I checked in for [e-mail], fixed.

Comment 6

[sairuh (rarely reading bugmail)]

vrfy'd fixed on linux rh8.0 and win2k with 2003.02.24 comm trunk bits.