1911701 - [wpt-sync] Sync PR 47476 - [Selection API] Add composed range endpoints

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47476 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47476
Details from upstream follow.

Di Zhang <[e-mail]> wrote:

[Selection API] Add composed range endpoints

We update Range API to support composed range. Previously, when setting
the start/end range endpoints, if they are in different node trees,
they will be collapsed. Now, if start/end are in different node trees,
but same document, composed_range_ will be set to track those cross
shadow tree endpoints.

We update Selection::GetComposedRanges to use composed start and end
to create a composed StaticRange.

We fix Selection::GetComposedRanges to use
IsShadowIncludingInclusiveAncestorOf for Rescoping and add a test.

Change-Id: Ib46497382fb83809394499182b5c8e4ee08925b7
Bug: 40286116
Fixed: 335245347
Fixed: 355630554
Reviewed-on: https://chromium-review.googlesource.com/5744732
WPT-Export-Revision: e277f22c32f417fa624e424f06fb3d639ddfa9aa

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0a21e59a27d5efca595160e7b22dce374c9bde62

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 12 subtests

Status Summary

Firefox

OK : 3
PASS : 13
FAIL : 2

Chrome

OK : 3
PASS : 11
FAIL : 4

Safari

OK : 2
PASS : 10
FAIL : 4
TIMEOUT: 1
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /shadow-dom/selection-getComposedRanges-collapsed.tentative.html [wpt.fyi]
  • Setting the range to nodes that aren't in the same tree collapses both composed and non-composed ranges.: FAIL (Chrome: PASS, Safari: FAIL)
• /shadow-dom/selection-getComposedRanges.tentative.html [wpt.fyi]
  • getComposedRanges should fail if argument is not a shadow root: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b174b86cad5
[wpt PR 47476] - [Selection API] Add composed range endpoints, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c87c681a11b9
[wpt PR 47476] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8b174b86cad5
https://hg.mozilla.org/mozilla-central/rev/c87c681a11b9