1911736 - Enable dom.popup.experimental on Nightly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Here is the try push with the preference enabled. Let's see what we get from the result.
https://treeherder.mozilla.org/jobs?repo=try&revision=3be3f9163e2690c099a96ef915a674fc5174cb7b

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1911736 - Enable dom.popup.experimental on Nightly, r=edgar,masayuki

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c76a33e9a09d
Enable dom.popup.experimental on Nightly, r=edgar

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures @ browser_osPicker.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/5ba9519a61269addfc4f80bd6bd386e41df44c46

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | accessible/tests/browser/windows/ia2/browser_osPicker.js | Uncaught exception in test bound - at chrome://mochitests/content/browser/accessible/tests/browser/shared-head.js

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

That revealed a real issue, bug 1924790

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9cecf978498
Enable dom.popup.experimental on Nightly, r=edgar

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a9cecf978498

Comment 8

[Donal Meehan [:dmeehan]]

:smaug could you consider nominating this for a release note? (Process info)
We could include it in the nightly only release notes.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Release Note Request (optional, but appreciated): Nightly only release note telling that user activation detection changes and popup blocking may be less strict in some cases, when it has been overly strict.
[Why is this notable]: This should help in certain cases when Firefox has been traditionally more (and overly) strict with popup blocking than other browsers. This should lead to fewer erroneous popup blocking prompts.
[Affects Firefox for Android]: Yes
[Suggested wording]: Firefox follows now more closely the model HTML specification has for transient user activation. [1]
[Links (documentation, blog post, etc)]:

[1] this is a bit hard to say precisely since HTML spec certain issues around this topic.

Comment 10

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx133 nightly release notes, please allow 30 minutes for the site to update.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Removing the nightly+ relnote flag since this is riding the 134 train to Release via bug 1927368.