1911841 - Port changes needed from |Bug 1476333 - Consolidate the ways that we reference "browser.xul" across the tree| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: General, task)

Description

[Ian Neal]

This ports the changes needed from patch 2 of Bug 1476333
Need to consolidate the ways that we access the main browser document URL. Here are the ways we currently access the main browser document URL:

• hardcoded "chrome://navigator/content/navigator.xul"
• hardcoded "chrome://navigator/content/" which redirects to "chrome://navigator/content/navigator.xul"
• Services.prefs.getCharPref("browser.chromeURL") -> "chrome://navigator/content/navigator.xul"
• getBrowserURL() from utilityOverlay.js / nsBrowserContentHandler.js

Comment 1

[Ian Neal]

Attachment: 1911841-browserChromeURL-25320.patch

[Approval Request Comment]
Regression caused by (bug #): 1476333
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): lowish
String changes made by this patch: none

Comment 2

[Ian Neal]

Attachment: 1911841-browserChromeURL-1_1-25320.patch

Wth AppConstants.jsm imported in utilityOverlay.js

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9433479 [details] [diff] [review]
1911841-browserChromeURL-1_1-25320.patch

lgtm

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ce70e5daa332
Port changes needed from |Bug 1476333 - Consolidate the ways that we reference "browser.xul" across the tree| to SeaMonkey. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/90d87144cca8996fc3f327f9eb83ac2d835faa7b
Port changes needed from |Bug 1476333 - Consolidate the ways that we reference "browser.xul" across the tree| to SeaMonkey. r=frg a=frg