Switch from boxObject to getBoundingClientRect in utilityOverlay
Categories
(SeaMonkey :: General, task)
Tracking
(seamonkey2.53? affected)
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
1.00 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment we get a message console about return (bo.height > 0 && bo.width > 0) in the function isElementVisible in utilityOverlay.js
Porting the relevant part of Bug 1519953 seems to fix the issue, potentially there are other parts that need porting but they could go into a second patch / follow-up bug.
[Approval Request Comment]
Regression caused by (bug #): unknown
User impact if declined: message in error console
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none
|
||
Updated•3 months ago
|
|
|
||
Comment 2•3 months ago
|
||
Comment on attachment 9417969 [details] [diff] [review]
1911844-boxObject-utilityOverlay-25320.patch
LGTM
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/9c8c8485588c
Switch from boxObject to getBoundingClientRect in utilityOverlay. r=frg
Description
•