1911845 - Adjust dragOver method of tabbrowser.xml to be closer to Firefox version

Status: RESOLVED FIXED

(SeaMonkey :: Tabbed Browser, enhancement)

Description

[Ian Neal]

At the moment the _onDragOver method is quite different to the Firefox version making it difficult to port future changes, so it makes sense to adjust it to be closer.

Comment 1

[Ian Neal]

Attachment: 1911845-tabbrowser-dragOver-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): lowish
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9417971 [details] [diff] [review]
1911845-tabbrowser-dragOver-25320.patch

lgtm.
Nit. Maybe in a followup after the code is baked add brackerts around if 'one-liners'.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/66a4156ebc9b
Adjust dragOver method of tabbrowser.xml to be closer to Firefox version. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/43ef911ba4c646535af915740f81cd1861be943d
Switch from boxObject to getBoundingClientRect in utilityOverlay. r=frg a=frg