Closed
Bug 1911845
Opened 6 months ago
Closed 3 months ago
Adjust dragOver method of tabbrowser.xml to be closer to Firefox version
Categories
(SeaMonkey :: Tabbed Browser, enhancement)
SeaMonkey
Tabbed Browser
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Whiteboard: SM2.53.20)
Attachments
(1 file)
|
5.61 KB,
patch
|
frg
:
review+
frg
:
approval-comm-release+
|
Details | Diff | Splinter Review |
At the moment the _onDragOver method is quite different to the Firefox version making it difficult to port future changes, so it makes sense to adjust it to be closer.
[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20
Risk to taking this patch (and alternatives if risky): lowish
String changes made by this patch: none
Attachment #9417971 -
Flags: review?(frgrahl)
Attachment #9417971 -
Flags: approval-comm-release?
Summary: Adjust dragOver method of tabbrowser.xml to be closer to Firefox → Adjust dragOver method of tabbrowser.xml to be closer to Firefox version
|
||
Comment 2•3 months ago
|
||
Comment on attachment 9417971 [details] [diff] [review]
1911845-tabbrowser-dragOver-25320.patch
lgtm.
Nit. Maybe in a followup after the code is baked add brackerts around if 'one-liners'.
Attachment #9417971 -
Flags: review?(frgrahl)
Attachment #9417971 -
Flags: review+
Attachment #9417971 -
Flags: approval-comm-release?
Attachment #9417971 -
Flags: approval-comm-release+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/66a4156ebc9b
Adjust dragOver method of tabbrowser.xml to be closer to Firefox version. r=frg
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•