1911906 - [wpt-sync] Sync PR 47494 - Nested view transition: reparent & render

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47494 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47494
Details from upstream follow.

Noam Rosenthal <[e-mail]> wrote:

Nested view transition: reparent & render

This tracks the view-transition-group for the captured elements
as "containing group". Those values are filtered to only include
ancestors.

• When a captured element has a valid containing group, the
  pseudo-element is reparented to the containing group when the
  view transition starts.

• Note that when capturing the old element, we don't deal with nesting
  at all. The tree for the purpose of allowing the compositor to
  capture the old state is flat. This can be revisited iteratively,
  it's done for implementation simplicity.

• When building styles, the (inverse) parent transform is adjusted
  so that it's not applied twice.

• Changed all the recursive functions to retrieve pseudo-elements
  to adapt to nested containers.

Currently, by default mismatches here are handled by
"last capture wins", however this is to be resolved in the CSSWG so it's not tested yet: https://github.com/w3c/csswg-drafts/issues/10631

Note also that with the current implementation, after capturing the
old state and before starting might appear broken, as
clipping/opacity/etc are not applied to the generated pseudo-element.

Bug: 347947051
Change-Id: I49e4f7ea6c8d82b6ad34b50f8cda92eb3f074612
Reviewed-on: https://chromium-review.googlesource.com/5749090
WPT-Export-Revision: a062f6a0ca51dbc77184a28130f8df7afcd5a00c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=24e86e2423ec5758414002cd2a3cff5d0282fbe0

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests

Status Summary

Firefox

PASS: 11

Chrome

PASS: 7
FAIL: 4

Safari

PASS: 4
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e2640fbdd8a
[wpt PR 47494] - Nested view transition: reparent & render, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/4e2640fbdd8a