1911922 - [wpt-sync] Sync PR 47499 - [layout] Rework block-size aspect-ratio logic.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 47499 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/47499
Details from upstream follow.

Ian Kilpatrick <[e-mail]> wrote:

[layout] Rework block-size aspect-ratio logic.

Similar to:
https://chromium-review.googlesource.com/c/chromium/src/+/5753989

Previously we had special logic to determine if we had an aspect-ratio
present, and manually resolve the size.

This changes what "auto" maps to when we have an aspect-ratio present.

This patch:

1. Checks if we can determine the block-size from the aspect-ratio,
   e.g. if we have a definite inline-size.
2. From this maps the "auto" length to "fit-content" when needed.
3. Changes the automatic minimum size logic to determine if our
   main length has a content-based size.

Bug: 40339056
Change-Id: I1338a957871004be53be98b834ae4853e88481aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5754643
Commit-Queue: Ian Kilpatrick \<[e-mail]>
Reviewed-by: David Baron \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1338154}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b2194f142c13dbb337a7877366cf487f7bc6528

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/calc-size/calc-size-aspect-ratio-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/159b4228af13
[wpt PR 47499] - [layout] Rework block-size aspect-ratio logic., a=testonly
https://hg.mozilla.org/integration/autoland/rev/682f1603be18
[wpt PR 47499] - Update wpt metadata, a=testonly

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/159b4228af13
https://hg.mozilla.org/mozilla-central/rev/682f1603be18